From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 992F21FF0AF for ; Fri, 20 Nov 2026 08:45:45 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7E2D6216B6; Fri, 20 Nov 2026 08:45:44 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Nov 2026 08:45:40 +0100 Message-Id: From: "Dominik Rusovac" To: "Fiona Ebner" , Subject: Re: [PATCH qemu-sever] api: remove blank line X-Mailer: aerc 0.20.0 References: <20261119124402.1822168-1-d.rusovac@proxmox.com> <29cdefbf-116f-4479-9758-be28bb2de91c@proxmox.com> In-Reply-To: <29cdefbf-116f-4479-9758-be28bb2de91c@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795160740225 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7U5ZT7PV36NVSD3AUDRDCIWMQY4B3UYF X-Message-ID-Hash: 7U5ZT7PV36NVSD3AUDRDCIWMQY4B3UYF X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Nov 19, 2026 at 4:21 PM CET, Fiona Ebner wrote: > Am 19.11.26 um 1:44 PM schrieb Dominik Rusovac: >> Signed-off-by: Dominik Rusovac >> --- >> src/PVE/API2/Qemu.pm | 1 - >> 1 file changed, 1 deletion(-) >>=20 >> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm >> index b798a590..e8c93df6 100644 >> --- a/src/PVE/API2/Qemu.pm >> +++ b/src/PVE/API2/Qemu.pm >> @@ -2395,7 +2395,6 @@ my $update_vm_api =3D sub { >> } >> =20 >> if ($param->{memory} || defined($param->{balloon})) { >> - >> my $memory =3D $param->{memory} || $conf->{pending}->{memor= y} || $conf->{memory}; >> my $maxmem =3D get_current_memory($memory); >> my $balloon =3D > > Our codebase has quite a few occurrences of such blank lines at the > start of branches. AFAICS, neither our style guide nor our perltidy > config enforce their absence. If we do want to change it, we should do > it there, and the next 'make tidy' will take care of it. Personally, I > prefer not having blanks in such places, but I'm not sure we have > consensus about that. I do also prefer not having blanks in such places just saw it by chance and thought I'd fix it in-place, but I agree with your suggestion, which is more sustainable imo