public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pve-network] sdn: vxlan: fix max value for vxlan-port
@ 2026-07-10  6:06 Hannes Laimer
  2026-09-09  9:47 ` Christoph Heiss
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2026-07-10  6:06 UTC (permalink / raw)
  To: pve-devel

As per RFC 768[1] the port is only 16 bits, so the maximum value is
65535. `ifupdown2` failed if 65536 was configured:

```
vxlan_yuuur : error: vxlan_yuuur: vxlan creation failed: 'H' format requires 0 <= number <= 65535
yuuur : error: yuuur: bridge port vxlan_yuuur does not exist
```

[1] https://datatracker.ietf.org/doc/html/rfc768

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 src/PVE/API2/Network/SDN/Zones.pm        | 2 +-
 src/PVE/Network/SDN/Zones/VxlanPlugin.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/API2/Network/SDN/Zones.pm b/src/PVE/API2/Network/SDN/Zones.pm
index b897cbd..e0b417b 100644
--- a/src/PVE/API2/Network/SDN/Zones.pm
+++ b/src/PVE/API2/Network/SDN/Zones.pm
@@ -187,7 +187,7 @@ my $ZONE_PROPERTIES = {
         description =>
             "UDP port that should be used for the VXLAN tunnel (default 4789). VXLAN zone only.",
         minimum => 1,
-        maximum => 65536,
+        maximum => 65535,
         type => 'integer',
         optional => 1,
         default => 4789,
diff --git a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
index a408261..1d6d588 100644
--- a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
+++ b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
@@ -35,7 +35,7 @@ sub properties {
         'vxlan-port' => {
             description => "UDP port that should be used for the VXLAN tunnel (default 4789).",
             minimum => 1,
-            maximum => 65536,
+            maximum => 65535,
             type => 'integer',
             default => 4789,
         },
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH pve-network] sdn: vxlan: fix max value for vxlan-port
  2026-07-10  6:06 [PATCH pve-network] sdn: vxlan: fix max value for vxlan-port Hannes Laimer
@ 2026-09-09  9:47 ` Christoph Heiss
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Heiss @ 2026-09-09  9:47 UTC (permalink / raw)
  To: Hannes Laimer; +Cc: pve-devel

On Fri Jul 10, 2026 at 8:06 AM CEST, Hannes Laimer wrote:
> As per RFC 768[1] the port is only 16 bits, so the maximum value is
> 65535. `ifupdown2` failed if 65536 was configured:

Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
Tested-by: Christoph Heiss <c.heiss@proxmox.com>

FWIW, interestingly, ifupdown2 also specifies 0-65536 as range and thus
accepts it. I'll send a patch fixing it there too.

>
> ```
> vxlan_yuuur : error: vxlan_yuuur: vxlan creation failed: 'H' format requires 0 <= number <= 65535
> yuuur : error: yuuur: bridge port vxlan_yuuur does not exist
> ```
>
> [1] https://datatracker.ietf.org/doc/html/rfc768
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  src/PVE/API2/Network/SDN/Zones.pm        | 2 +-
>  src/PVE/Network/SDN/Zones/VxlanPlugin.pm | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/API2/Network/SDN/Zones.pm b/src/PVE/API2/Network/SDN/Zones.pm
> index b897cbd..e0b417b 100644
> --- a/src/PVE/API2/Network/SDN/Zones.pm
> +++ b/src/PVE/API2/Network/SDN/Zones.pm
> @@ -187,7 +187,7 @@ my $ZONE_PROPERTIES = {
>          description =>
>              "UDP port that should be used for the VXLAN tunnel (default 4789). VXLAN zone only.",
>          minimum => 1,
> -        maximum => 65536,
> +        maximum => 65535,
>          type => 'integer',
>          optional => 1,
>          default => 4789,
> diff --git a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
> index a408261..1d6d588 100644
> --- a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
> +++ b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
> @@ -35,7 +35,7 @@ sub properties {
>          'vxlan-port' => {
>              description => "UDP port that should be used for the VXLAN tunnel (default 4789).",
>              minimum => 1,
> -            maximum => 65536,
> +            maximum => 65535,
>              type => 'integer',
>              default => 4789,
>          },






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-09  9:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-10  6:06 [PATCH pve-network] sdn: vxlan: fix max value for vxlan-port Hannes Laimer
2026-09-09  9:47 ` Christoph Heiss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal