From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Hannes Laimer" <h.laimer@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-network] sdn: vxlan: fix max value for vxlan-port
Date: Wed, 09 Sep 2026 11:47:18 +0200 [thread overview]
Message-ID: <DLAOVBNRIAWZ.2PCH6OQ0TYXR2@proxmox.com> (raw)
In-Reply-To: <20260710060648.50963-1-h.laimer@proxmox.com>
On Fri Jul 10, 2026 at 8:06 AM CEST, Hannes Laimer wrote:
> As per RFC 768[1] the port is only 16 bits, so the maximum value is
> 65535. `ifupdown2` failed if 65536 was configured:
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
Tested-by: Christoph Heiss <c.heiss@proxmox.com>
FWIW, interestingly, ifupdown2 also specifies 0-65536 as range and thus
accepts it. I'll send a patch fixing it there too.
>
> ```
> vxlan_yuuur : error: vxlan_yuuur: vxlan creation failed: 'H' format requires 0 <= number <= 65535
> yuuur : error: yuuur: bridge port vxlan_yuuur does not exist
> ```
>
> [1] https://datatracker.ietf.org/doc/html/rfc768
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> src/PVE/API2/Network/SDN/Zones.pm | 2 +-
> src/PVE/Network/SDN/Zones/VxlanPlugin.pm | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/API2/Network/SDN/Zones.pm b/src/PVE/API2/Network/SDN/Zones.pm
> index b897cbd..e0b417b 100644
> --- a/src/PVE/API2/Network/SDN/Zones.pm
> +++ b/src/PVE/API2/Network/SDN/Zones.pm
> @@ -187,7 +187,7 @@ my $ZONE_PROPERTIES = {
> description =>
> "UDP port that should be used for the VXLAN tunnel (default 4789). VXLAN zone only.",
> minimum => 1,
> - maximum => 65536,
> + maximum => 65535,
> type => 'integer',
> optional => 1,
> default => 4789,
> diff --git a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
> index a408261..1d6d588 100644
> --- a/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
> +++ b/src/PVE/Network/SDN/Zones/VxlanPlugin.pm
> @@ -35,7 +35,7 @@ sub properties {
> 'vxlan-port' => {
> description => "UDP port that should be used for the VXLAN tunnel (default 4789).",
> minimum => 1,
> - maximum => 65536,
> + maximum => 65535,
> type => 'integer',
> default => 4789,
> },
prev parent reply other threads:[~2026-09-09 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 6:06 [PATCH pve-network] sdn: vxlan: fix max value for vxlan-port Hannes Laimer
2026-09-09 9:47 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLAOVBNRIAWZ.2PCH6OQ0TYXR2@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox