Re: [PATCH pve-storage v3 1/2] qemu-img: drop redundant timeout argument at resize call

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

Last patch (v2) I also didn't consider that thrid-party plugins would
call qemu_img_resize. Therefore keeping the $timeout parameter is
definitely the correct choice.

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Tue Aug 11, 2026 at 9:37 AM CEST, Jakob Klocker wrote:
> `qemu_img_resize` already defaults to a timeout of 10 seconds when none
> is passed, so passing 10 explicitly is redundant.
>
> Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
> ---
>  src/PVE/Storage/LVMPlugin.pm | 2 +-
>  src/PVE/Storage/Plugin.pm    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
> index b8646c2..768ff95 100644
> --- a/src/PVE/Storage/LVMPlugin.pm
> +++ b/src/PVE/Storage/LVMPlugin.pm
> @@ -1081,7 +1081,7 @@ sub volume_resize {
>  
>      if (!$running && $format eq 'qcow2') {
>          my $preallocation = PVE::Storage::Plugin::preallocation_cmd_opt($scfg, $format);
> -        PVE::Storage::Common::qemu_img_resize($path, $format, $size, $preallocation, 10);
> +        PVE::Storage::Common::qemu_img_resize($path, $format, $size, $preallocation);
>      }
>  
>      return 1;
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 4f69f9b..082355d 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -1373,7 +1373,7 @@ sub volume_resize {
>      my $format = ($class->parse_volname($volname))[6];
>  
>      my $preallocation = preallocation_cmd_opt($scfg, $format);
> -    PVE::Storage::Common::qemu_img_resize($path, $format, $size, $preallocation, 10);
> +    PVE::Storage::Common::qemu_img_resize($path, $format, $size, $preallocation);
>  
>      return undef;
>  }