Re: [PATCH pve-storage v3 2/2] fix #7598: qemu-img: increase timeout for image resizing in worker context

["Elias Huhsovitz" <e.huhsovitz@proxmox.com>]

Tested again using 

pvesh set /nodes/{node}/qemu/{vmid}/resize --disk scsi0 --size +{num}G

and the GUI option VM->Disk Action->Resize

Which correctly set the $timeout=3600 in the worker context as intended.

Reviewed-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Tested-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>

On Tue Aug 11, 2026 at 9:37 AM CEST, Jakob Klocker wrote:
> Mirror ZFS behaviour and increase timeout to an hour when in a worker
> context. This fixes issues some users [0] have with slow disks where a
> resize would fail.
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=7598
>
> Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
> ---
>  src/PVE/Storage/Common.pm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm
> index 3932aee..1c3fdad 100644
> --- a/src/PVE/Storage/Common.pm
> +++ b/src/PVE/Storage/Common.pm
> @@ -3,6 +3,7 @@ package PVE::Storage::Common;
>  use v5.36;
>  
>  use PVE::JSONSchema;
> +use PVE::RPCEnvironment;
>  use PVE::Syscall;
>  use PVE::Tools qw(run_command);
>  
> @@ -262,8 +263,8 @@ sub qemu_img_measure {
>      qemu_img_resize($path, $format, $size, $preallocation, $timeout)
>  
>  Resize a qemu image C<$path> with format C<$format> to a target Kb size C<$size>.
> -Default timeout C<$timeout> is 10s if not specified.
>  C<$preallocation> allows to specify the preallocation option for the resize operation.
> +If no C<$timeout> is provided, it defaults to 10 seconds, or 1 hour when running in a worker context.
>  
>  =cut
>  
> @@ -276,7 +277,8 @@ sub qemu_img_resize {
>      push $cmd->@*, "--preallocation=$preallocation" if $preallocation;
>      push $cmd->@*, '-f', $format, $path, $size;
>  
> -    $timeout = 10 if !$timeout;
> +    $timeout = PVE::RPCEnvironment->is_worker() ? 60 * 60 : 10
> +        if !$timeout;
>      run_command($cmd, timeout => $timeout);
>  }
>