From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 51BD41FF13C for ; Thu, 13 Aug 2026 11:04:41 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 360DB21579; Thu, 13 Aug 2026 11:04:38 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 13 Aug 2026 11:04:29 +0200 Message-Id: Subject: Re: [PATCH pve-storage v3 1/2] qemu-img: drop redundant timeout argument at resize call From: "Elias Huhsovitz" To: "Jakob Klocker" , X-Mailer: aerc 0.20.0 References: <20260811073740.100398-1-j.klocker@proxmox.com> <20260811073740.100398-2-j.klocker@proxmox.com> In-Reply-To: <20260811073740.100398-2-j.klocker@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786611853746 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.818 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: B6GZIQALLW5NGHAL2F5D2EW4KWRYV7V6 X-Message-ID-Hash: B6GZIQALLW5NGHAL2F5D2EW4KWRYV7V6 X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Last patch (v2) I also didn't consider that thrid-party plugins would call qemu_img_resize. Therefore keeping the $timeout parameter is definitely the correct choice. Reviewed-by: Elias Huhsovitz Tested-by: Elias Huhsovitz On Tue Aug 11, 2026 at 9:37 AM CEST, Jakob Klocker wrote: > `qemu_img_resize` already defaults to a timeout of 10 seconds when none > is passed, so passing 10 explicitly is redundant. > > Signed-off-by: Jakob Klocker > --- > src/PVE/Storage/LVMPlugin.pm | 2 +- > src/PVE/Storage/Plugin.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm > index b8646c2..768ff95 100644 > --- a/src/PVE/Storage/LVMPlugin.pm > +++ b/src/PVE/Storage/LVMPlugin.pm > @@ -1081,7 +1081,7 @@ sub volume_resize { > =20 > if (!$running && $format eq 'qcow2') { > my $preallocation =3D PVE::Storage::Plugin::preallocation_cmd_op= t($scfg, $format); > - PVE::Storage::Common::qemu_img_resize($path, $format, $size, $pr= eallocation, 10); > + PVE::Storage::Common::qemu_img_resize($path, $format, $size, $pr= eallocation); > } > =20 > return 1; > diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm > index 4f69f9b..082355d 100644 > --- a/src/PVE/Storage/Plugin.pm > +++ b/src/PVE/Storage/Plugin.pm > @@ -1373,7 +1373,7 @@ sub volume_resize { > my $format =3D ($class->parse_volname($volname))[6]; > =20 > my $preallocation =3D preallocation_cmd_opt($scfg, $format); > - PVE::Storage::Common::qemu_img_resize($path, $format, $size, $preall= ocation, 10); > + PVE::Storage::Common::qemu_img_resize($path, $format, $size, $preall= ocation); > =20 > return undef; > }