public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
To: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>,
	<pve-devel@lists.proxmox.com>
Subject: Re: [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute paths as volume ids
Date: Wed, 22 Jul 2026 16:10:24 +0200	[thread overview]
Message-ID: <DK55S2XVSBGA.30HO2UIRGSY8B@proxmox.com> (raw)
In-Reply-To: <20260722095251.89606-3-t.ellmenreich@proxmox.com>

Small typo, otherwise see review by fiona Ebner [1].

[1:] https://lore.proxmox.com/all/8abb29af-e16d-456b-ab14-cd423abdd801@proxmox.com/

On Wed Jul 22, 2026 at 11:52 AM CEST, Thomas Ellmenreich wrote:
> Just like in the case of cdroms, absolute paths to storage drives can be
> skipped when beeing marked as unused as they cannot be owned by the vm.
		^^^
		small typo
>
> Fixes: 5b5c5768 ("display warnings for storage errors or if storage no longer exists")
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  src/PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index ce832c8e..ce0eda74 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1575,7 +1575,7 @@ sub vmconfig_register_unused_drive {
>          eval { PVE::Storage::vdisk_free($storecfg, $drive->{file}) };
>          warn $@ if $@;
>          delete $conf->{'special-sections'}->{cloudinit};
> -    } elsif (!drive_is_cdrom($drive)) {
> +    } elsif (!drive_is_cdrom($drive) && !drive_is_absolute_path($drive)) {
>          my $volid = $drive->{file};
>          my ($storeid, undef) = PVE::Storage::parse_volume_id($volid);
>          if (PVE::Storage::storage_config($storecfg, $storeid, 1)) {





      parent reply	other threads:[~2026-07-22 14:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  9:52 [PATCH qemu-server v2 0/2] fix #7828: avoid parsing absolute paths as volume ids Thomas Ellmenreich
2026-07-22  9:52 ` [PATCH qemu-server v2 1/2] refactor checks for absolute path as drive Thomas Ellmenreich
2026-07-22 12:45   ` Daniel Kral
2026-07-22 13:40     ` Thomas Ellmenreich
2026-07-22 14:01     ` Fiona Ebner
2026-07-22  9:52 ` [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute paths as volume ids Thomas Ellmenreich
2026-07-22 13:01   ` Fiona Ebner
2026-07-22 13:11     ` Thomas Ellmenreich
2026-07-22 14:10   ` Elias Huhsovitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK55S2XVSBGA.30HO2UIRGSY8B@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.ellmenreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal