From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH qemu-server v2 1/2] refactor checks for absolute path as drive
Date: Wed, 22 Jul 2026 15:40:55 +0200 [thread overview]
Message-ID: <DK555I8EPZI8.PUKS3BWINELR@proxmox.com> (raw)
In-Reply-To: <DK53YSH7NPZ2.1SP4SG7GC2J11@proxmox.com>
On Wed Jul 22, 2026 at 2:45 PM CEST, Daniel Kral wrote:
[snip]
> Hm, the !$volid check should be included in the check above as well as
> drive_is_absolute_path() doesn't check this and shouldn't need to.
>
> Though if there's good reason that !$volid will never be true here, this
> can be removed in a previous commit with a clear reasoning why.
Good catch, was a thinking mistake on my part. Thought the `!volid`
check was unnecessary because the regex cleanly handles it, although
that misses the point. Will reintroduce it.
[snip]
next prev parent reply other threads:[~2026-07-22 13:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 9:52 [PATCH qemu-server v2 0/2] fix #7828: avoid parsing absolute paths as volume ids Thomas Ellmenreich
2026-07-22 9:52 ` [PATCH qemu-server v2 1/2] refactor checks for absolute path as drive Thomas Ellmenreich
2026-07-22 12:45 ` Daniel Kral
2026-07-22 13:40 ` Thomas Ellmenreich [this message]
2026-07-22 14:01 ` Fiona Ebner
2026-07-22 9:52 ` [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute paths as volume ids Thomas Ellmenreich
2026-07-22 13:01 ` Fiona Ebner
2026-07-22 13:11 ` Thomas Ellmenreich
2026-07-22 14:10 ` Elias Huhsovitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK555I8EPZI8.PUKS3BWINELR@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox