Re: [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute paths as volume ids

[Fiona Ebner <f.ebner@proxmox.com>]

Am 22.07.26 um 11:53 AM schrieb Thomas Ellmenreich:
> Just like in the case of cdroms, absolute paths to storage drives can be
> skipped when beeing marked as unused as they cannot be owned by the vm.
> 
> Fixes: 5b5c5768 ("display warnings for storage errors or if storage no longer exists")
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  src/PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index ce832c8e..ce0eda74 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1575,7 +1575,7 @@ sub vmconfig_register_unused_drive {
>          eval { PVE::Storage::vdisk_free($storecfg, $drive->{file}) };
>          warn $@ if $@;
>          delete $conf->{'special-sections'}->{cloudinit};
> -    } elsif (!drive_is_cdrom($drive)) {
> +    } elsif (!drive_is_cdrom($drive) && !drive_is_absolute_path($drive)) {
>          my $volid = $drive->{file};
>          my ($storeid, undef) = PVE::Storage::parse_volume_id($volid);

To fix the regression, I would prefer to use the noerr variant of
parse_volume_id() here, because that is what tells us whether the volume
is PVE-managed or not. We already do that in some other places like
import. And then continue only if we got a result for $storeid.

>          if (PVE::Storage::storage_config($storecfg, $storeid, 1)) {