all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Subject: [PATCH qemu-server v2 0/2] fix #7828: avoid parsing absolute paths as volume ids.
Date: Wed, 22 Jul 2026 11:52:49 +0200	[thread overview]
Message-ID: <20260722095251.89606-1-t.ellmenreich@proxmox.com> (raw)

This series refactors all checks of drive and volume ids as absolute paths
into two separate helper functions, and uses them in all occurrences of such
checks.

The new helper functions are then also applied to make sure that drives that
are absolute paths are not added as unused drives to a vm. Just like is the
case for cdrom drives.

This issue was reported in the community forum: [0]. The issue arose, as
@Daniel Kral mentioned, because of the addition of the config check and parsing
of the volume id with commit: 5b5c5768, which did not consider the possibility
of absolute paths as volume ids.

Changes since v1:

- Prepended an additional patch to introduce the two helper functions, as the
  check for absolute paths was performed a considerable amount of times.

- Use of the created helper functions:

- Addition of the "Fixes 5b..." to the commit message

[0]: https://forum.proxmox.com/threads/possible-regression-in-pve-9-2-x-unable-to-remove-physical-passthrough-disks-using-qm-set-delete.185191/


qemu-manager:

Thomas Ellmenreich (2):
  refactor checks for absolute path as drive
  fix #7828: avoid parsing absolute paths as volume ids

 src/PVE/QemuConfig.pm          |  2 +-
 src/PVE/QemuMigrate.pm         |  2 +-
 src/PVE/QemuServer.pm          | 22 +++++++++-------------
 src/PVE/QemuServer/Blockdev.pm |  4 ++--
 src/PVE/QemuServer/Drive.pm    |  8 +++++++-
 src/PVE/QemuServer/Helpers.pm  |  5 +++++
 6 files changed, 25 insertions(+), 18 deletions(-)


Summary over all repositories:
  6 files changed, 25 insertions(+), 18 deletions(-)

-- 
Generated by murpp 0.12.0




             reply	other threads:[~2026-07-22  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  9:52 Thomas Ellmenreich [this message]
2026-07-22  9:52 ` [PATCH qemu-server v2 1/2] refactor checks for absolute path as drive Thomas Ellmenreich
2026-07-22 12:45   ` Daniel Kral
2026-07-22 13:40     ` Thomas Ellmenreich
2026-07-22 14:01     ` Fiona Ebner
2026-07-22  9:52 ` [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute paths as volume ids Thomas Ellmenreich
2026-07-22 13:01   ` Fiona Ebner
2026-07-22 13:11     ` Thomas Ellmenreich
2026-07-22 14:10   ` Elias Huhsovitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722095251.89606-1-t.ellmenreich@proxmox.com \
    --to=t.ellmenreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal