From: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>,
<pve-devel@lists.proxmox.com>, <d.kral@proxmox.com>
Subject: Re: [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute paths as volume ids
Date: Wed, 22 Jul 2026 15:11:59 +0200 [thread overview]
Message-ID: <DK54JCSS2HU1.14PDCQ5Q6LYFM@proxmox.com> (raw)
In-Reply-To: <8abb29af-e16d-456b-ab14-cd423abdd801@proxmox.com>
> To fix the regression, I would prefer to use the noerr variant of
> parse_volume_id() here, because that is what tells us whether the volume
> is PVE-managed or not. We already do that in some other places like
> import. And then continue only if we got a result for $storeid.
That sounds like a better solution for me, what do you think @Daniel?
next prev parent reply other threads:[~2026-07-22 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 9:52 [PATCH qemu-server v2 0/2] fix #7828: avoid parsing absolute paths as volume ids Thomas Ellmenreich
2026-07-22 9:52 ` [PATCH qemu-server v2 1/2] refactor checks for absolute path as drive Thomas Ellmenreich
2026-07-22 12:45 ` Daniel Kral
2026-07-22 13:40 ` Thomas Ellmenreich
2026-07-22 14:01 ` Fiona Ebner
2026-07-22 9:52 ` [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute paths as volume ids Thomas Ellmenreich
2026-07-22 13:01 ` Fiona Ebner
2026-07-22 13:11 ` Thomas Ellmenreich [this message]
2026-07-22 14:10 ` Elias Huhsovitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK54JCSS2HU1.14PDCQ5Q6LYFM@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.