From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 211131FF138 for ; Wed, 22 Jul 2026 11:54:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A77A121519; Wed, 22 Jul 2026 11:53:48 +0200 (CEST) From: Thomas Ellmenreich To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 0/2] fix #7828: avoid parsing absolute paths as volume ids. Date: Wed, 22 Jul 2026 11:52:49 +0200 Message-ID: <20260722095251.89606-1-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784713965994 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.145 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: G72VEN3XGUQRV6KTARBARSWABTKLNPPO X-Message-ID-Hash: G72VEN3XGUQRV6KTARBARSWABTKLNPPO X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This series refactors all checks of drive and volume ids as absolute paths into two separate helper functions, and uses them in all occurrences of such checks. The new helper functions are then also applied to make sure that drives that are absolute paths are not added as unused drives to a vm. Just like is the case for cdrom drives. This issue was reported in the community forum: [0]. The issue arose, as @Daniel Kral mentioned, because of the addition of the config check and parsing of the volume id with commit: 5b5c5768, which did not consider the possibility of absolute paths as volume ids. Changes since v1: - Prepended an additional patch to introduce the two helper functions, as the check for absolute paths was performed a considerable amount of times. - Use of the created helper functions: - Addition of the "Fixes 5b..." to the commit message [0]: https://forum.proxmox.com/threads/possible-regression-in-pve-9-2-x-unable-to-remove-physical-passthrough-disks-using-qm-set-delete.185191/ qemu-manager: Thomas Ellmenreich (2): refactor checks for absolute path as drive fix #7828: avoid parsing absolute paths as volume ids src/PVE/QemuConfig.pm | 2 +- src/PVE/QemuMigrate.pm | 2 +- src/PVE/QemuServer.pm | 22 +++++++++------------- src/PVE/QemuServer/Blockdev.pm | 4 ++-- src/PVE/QemuServer/Drive.pm | 8 +++++++- src/PVE/QemuServer/Helpers.pm | 5 +++++ 6 files changed, 25 insertions(+), 18 deletions(-) Summary over all repositories: 6 files changed, 25 insertions(+), 18 deletions(-) -- Generated by murpp 0.12.0