From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Jakob Klocker" <j.klocker@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH qemu-server] fix #7697: snapshot hook name mismatch
Date: Tue, 23 Jun 2026 16:16:06 +0200 [thread overview]
Message-ID: <DJGHQNDDSOJS.3205PL0Q75D0H@proxmox.com> (raw)
In-Reply-To: <20260612100758.116697-1-j.klocker@proxmox.com>
Tested this in combination with the fix for #5032 [0]. With this patch
applied, the hook is called as expected.
The changes look simple enough. Had a look at how the hook is called
when a snapshot is made and it seems correct to me that this should be
after-unfreeze.
Consider this:
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
[0] https://lore.proxmox.com/pve-devel/20260622134711.108611-1-j.klocker@proxmox.com/
On Fri Jun 12, 2026 at 12:07 PM CEST, Jakob Klocker wrote:
> pve-guest-common invokes the snapshot hook with the name
> "after-unfreeze" [0], but qemu-server checks for "after-freeze" [1].
[snip]
next prev parent reply other threads:[~2026-06-23 14:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 10:07 [PATCH qemu-server] fix #7697: snapshot hook name mismatch Jakob Klocker
2026-06-18 12:40 ` Arthur Bied-Charreton
2026-06-23 14:16 ` Michael Köppl [this message]
2026-06-24 10:35 ` applied: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJGHQNDDSOJS.3205PL0Q75D0H@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox