From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Jakob Klocker <j.klocker@proxmox.com>
Subject: applied: [PATCH qemu-server] fix #7697: snapshot hook name mismatch
Date: Wed, 24 Jun 2026 12:35:37 +0200 [thread overview]
Message-ID: <178229709150.155867.11006975108293964297.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260612100758.116697-1-j.klocker@proxmox.com>
On Fri, 12 Jun 2026 12:07:58 +0200, Jakob Klocker wrote:
> pve-guest-common invokes the snapshot hook with the name
> "after-unfreeze" [0], but qemu-server checks for "after-freeze" [1].
>
> As a result, the post-unfreeze hook is never executed and the
> query-savevm polling loop intended to wait for savevm-end cleanup
> is skipped.
Applied, thanks! I modeled the test more closely after the actual
behavior, returning an empty JSON object after the savevm operation
has ended. This also required unsetting the savevm_ended property in
the test upon savevm-start. In a follow-up, I updated the existing
message in the loop to hopefully be a bit clearer to end-users.
[1/1] fix #7697: snapshot hook name mismatch
commit: 568b295c7b425e16b8fd3f5b7fe1cfe7bcce94d9
prev parent reply other threads:[~2026-06-24 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 10:07 [PATCH qemu-server] fix #7697: snapshot hook name mismatch Jakob Klocker
2026-06-18 12:40 ` Arthur Bied-Charreton
2026-06-23 14:16 ` Michael Köppl
2026-06-24 10:35 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178229709150.155867.11006975108293964297.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox