From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4455E1FF13A for ; Wed, 24 Jun 2026 12:36:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 42BB01510B; Wed, 24 Jun 2026 12:36:23 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Jakob Klocker Subject: applied: [PATCH qemu-server] fix #7697: snapshot hook name mismatch Date: Wed, 24 Jun 2026 12:35:37 +0200 Message-ID: <178229709150.155867.11006975108293964297.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260612100758.116697-1-j.klocker@proxmox.com> References: <20260612100758.116697-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782297336662 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VNA4AUZBK2I7675S74DWWFNEFKHERHSU X-Message-ID-Hash: VNA4AUZBK2I7675S74DWWFNEFKHERHSU X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 12 Jun 2026 12:07:58 +0200, Jakob Klocker wrote: > pve-guest-common invokes the snapshot hook with the name > "after-unfreeze" [0], but qemu-server checks for "after-freeze" [1]. > > As a result, the post-unfreeze hook is never executed and the > query-savevm polling loop intended to wait for savevm-end cleanup > is skipped. Applied, thanks! I modeled the test more closely after the actual behavior, returning an empty JSON object after the savevm operation has ended. This also required unsetting the savevm_ended property in the test upon savevm-start. In a follow-up, I updated the existing message in the loop to hopefully be a bit clearer to end-users. [1/1] fix #7697: snapshot hook name mismatch commit: 568b295c7b425e16b8fd3f5b7fe1cfe7bcce94d9