From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DE5851FF146 for ; Tue, 23 Jun 2026 16:16:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A09282619; Tue, 23 Jun 2026 16:16:11 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 23 Jun 2026 16:16:06 +0200 Message-Id: Subject: Re: [PATCH qemu-server] fix #7697: snapshot hook name mismatch From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Jakob Klocker" , X-Mailer: aerc 0.21.0 References: <20260612100758.116697-1-j.klocker@proxmox.com> In-Reply-To: <20260612100758.116697-1-j.klocker@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782224155932 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: URCCRLA3PKTMCXYROAONVIBTUMKP7ANN X-Message-ID-Hash: URCCRLA3PKTMCXYROAONVIBTUMKP7ANN X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Tested this in combination with the fix for #5032 [0]. With this patch applied, the hook is called as expected. The changes look simple enough. Had a look at how the hook is called when a snapshot is made and it seems correct to me that this should be after-unfreeze. Consider this: Tested-by: Michael K=C3=B6ppl =20 Reviewed-by: Michael K=C3=B6ppl =20 [0] https://lore.proxmox.com/pve-devel/20260622134711.108611-1-j.klocker@pr= oxmox.com/ On Fri Jun 12, 2026 at 12:07 PM CEST, Jakob Klocker wrote: > pve-guest-common invokes the snapshot hook with the name > "after-unfreeze" [0], but qemu-server checks for "after-freeze" [1]. [snip]