From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Hannes Laimer" <h.laimer@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH installer 4/8] sys: net: drop the now-unused `ipconf` runtime environment configuration
Date: Mon, 11 May 2026 12:00:38 +0200 [thread overview]
Message-ID: <DIFRDM6HV0UR.2Y6W03DNRTBOV@proxmox.com> (raw)
In-Reply-To: <9afb6cab-e0eb-4b61-80b1-b38702f861b5@proxmox.com>
Thanks for the review!
On Mon May 11, 2026 at 10:55 AM CEST, Hannes Laimer wrote:
> `$run_env->{ipconfig}` is still accessed in `extract_data` (Install.pm)
> we should probably just use `$run_env->{network}->{interfaces}` like we
> do for pinning
Again good catch, thanks! If nothing else comes up, I'll send a v2
later.
next prev parent reply other threads:[~2026-05-11 10:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 18:44 [PATCH installer 0/8] add IPv6 SLAAC and v6-only support Christoph Heiss
2026-05-08 18:44 ` [PATCH installer 1/8] install: drop trivial fromjs() wrapper and use JSON::from_json() Christoph Heiss
2026-05-08 18:44 ` [PATCH installer 2/8] install: move network subroutines to Proxmox::Sys::Net Christoph Heiss
2026-05-08 18:44 ` [PATCH installer 3/8] gui: use run_env->{network} instead of old run_env->{ipconf} Christoph Heiss
2026-05-11 9:09 ` Hannes Laimer
2026-05-11 9:59 ` Christoph Heiss
2026-05-08 18:44 ` [PATCH installer 4/8] sys: net: drop the now-unused `ipconf` runtime environment configuration Christoph Heiss
2026-05-11 8:55 ` Hannes Laimer
2026-05-11 10:00 ` Christoph Heiss [this message]
2026-05-08 18:44 ` [PATCH installer 5/8] sys: net: allow up to /128 netmask for IPv6 Christoph Heiss
2026-05-08 18:44 ` [PATCH RFC installer 6/8] sys: net: ignore ipv6 nameservers with zone identifiers Christoph Heiss
2026-05-08 18:44 ` [PATCH installer 7/8] common: options: rework network address setup to handle ipv6-only Christoph Heiss
2026-05-08 18:44 ` [PATCH installer 8/8] unconfigured: try to retrieve IPv6 SLAAC addresses on startup Christoph Heiss
2026-05-11 9:40 ` [PATCH installer 0/8] add IPv6 SLAAC and v6-only support Gabriel Goller
2026-05-11 15:59 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIFRDM6HV0UR.2Y6W03DNRTBOV@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox