Re: [PATCH installer 4/8] sys: net: drop the now-unused `ipconf` runtime environment configuration

[Hannes Laimer <h.laimer@proxmox.com>]

`$run_env->{ipconfig}` is still accessed in `extract_data` (Install.pm)
we should probably just use `$run_env->{network}->{interfaces}` like we
do for pinning

On 2026-05-08 20:45, Christoph Heiss wrote:
> $run_env->{ipconf} is now completely unused, thus drop the dead code.
> 
> No functional changes.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  Proxmox/Install/RunEnv.pm |  6 ----
>  Proxmox/Sys/Net.pm        | 71 ++-------------------------------------
>  2 files changed, 2 insertions(+), 75 deletions(-)
> 
> diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm
> index b83b9ff..d226ce1 100644
> --- a/Proxmox/Install/RunEnv.pm
> +++ b/Proxmox/Install/RunEnv.pm
> @@ -136,7 +136,6 @@ my sub detect_country_tracing_to : prototype($$) {
>  # {
>  #     arch => <dpkg architecture, e.g. 'amd64' or 'arm64'>,
>  #     country => <short country>,
> -#     ipconf = <see Proxmox::Sys::Net::get_ip_config()>,
>  #     kernel_cmdline = <contents of /proc/cmdline>,
>  #     total_memory = <memory size in MiB>,
>  #     hvm_supported = <1 if the CPU supports hardware-accelerated virtualization>,
> @@ -187,11 +186,6 @@ sub query_installation_environment : prototype() {
>          $output->{network}->{hostname} = $fqdn;
>      }
>  
> -    # FIXME: move whatever makes sense over to Proxmox::Sys::Net:: and keep that as single source,
> -    # it can then use some different structure just fine (after adapting the GTK GUI to that) but
> -    # **never** to (slightly different!) things for the same stuff...
> -    $output->{ipconf} = Proxmox::Sys::Net::get_ip_config();
> -
>      $output->{kernel_cmdline} = file_read_firstline("/proc/cmdline");
>      $output->{total_memory} = query_total_memory();
>  
> diff --git a/Proxmox/Sys/Net.pm b/Proxmox/Sys/Net.pm
> index 10144e0..52615ac 100644
> --- a/Proxmox/Sys/Net.pm
> +++ b/Proxmox/Sys/Net.pm
> @@ -186,78 +186,11 @@ sub get_pin_link_file_content {
>      return sprintf($LINK_FILE_TEMPLATE, $mac, $pin_name);
>  }
>  
> -sub get_ip_config {
> -    my $ifaces = {};
> -    my $default;
> -    my $pinned_counter = 0;
> -
> -    my $links = `ip -o l`;
> -    foreach my $l (split /\n/, $links) {
> -        my ($index, $name, $flags, $state, $mac) =
> -            $l =~ m/^(\d+):\s+(\S+):\s+<(\S+)>.*\s+state\s+(\S+)\s+.*\s+link\/ether\s+(\S+)\s+/;
> -        next if !$name || $name eq 'lo';
> -
> -        my $driver = readlink "/sys/class/net/$name/device/driver" || 'unknown';
> -        $driver =~ s!^.*/!!;
> -
> -        $ifaces->{"$index"} = {
> -            name => $name,
> -            pinned_id => "${pinned_counter}",
> -            driver => $driver,
> -            flags => $flags,
> -            state => $state,
> -            mac => $mac,
> -        };
> -        $pinned_counter++;
> -
> -        my $addresses = `ip -o a s $name`;
> -        for my $addr_line (split /\n/, $addresses) {
> -            my ($family, $ip, $prefix) =
> -                $addr_line =~ m/^\Q$index\E:\s+\Q$name\E\s+(inet|inet6)\s+($IPRE)\/(\d+)\s+/;
> -            next if !$ip;
> -            next if $addr_line =~ /scope\s+link/; # ignore link local
> -
> -            my $mask = $prefix;
> -
> -            if ($family eq 'inet') {
> -                next if !$ip =~ /$IPV4RE/;
> -                next if $prefix < 8 || $prefix > 32;
> -                $mask = @$ipv4_reverse_mask[$prefix];
> -            } else {
> -                next if !$ip =~ /$IPV6RE/;
> -            }
> -
> -            $default = $index if !$default;
> -
> -            $ifaces->{"$index"}->{"$family"} = {
> -                prefix => $prefix,
> -                mask => $mask,
> -                addr => $ip,
> -            };
> -        }
> -    }
> -
> -    my $route = `ip route`;
> -    my ($gateway) = $route =~ m/^default\s+via\s+(\S+)\s+/m;
> -
> -    my $resolvconf = `cat /etc/resolv.conf`;
> -    my ($dnsserver) = $resolvconf =~ m/^nameserver\s+(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})$/m;
> -    my ($domain) = $resolvconf =~ m/^domain\s+(\S+)$/m;
> -
> -    return {
> -        default => $default,
> -        ifaces => $ifaces,
> -        gateway => $gateway,
> -        dnsserver => $dnsserver,
> -        domain => $domain,
> -    };
> -}
> -
>  sub udevadm_netdev_details {
> -    my $ip_config = get_ip_config();
> +    my $ifaces = query_netdevs();
>  
>      my $result = {};
> -    for my $dev (values $ip_config->{ifaces}->%*) {
> +    for my $dev (values $ifaces->%*) {
>          my $name = $dev->{name};
>          $result->{$name} = Proxmox::Sys::Udev::get_udev_properties("/sys/class/net/$name");
>      }