From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id E8B921FF133
	for <inbox@lore.proxmox.com>; Mon, 11 May 2026 12:01:12 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id BC47D1254B;
	Mon, 11 May 2026 12:01:12 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 11 May 2026 12:00:38 +0200
Message-Id: <DIFRDM6HV0UR.2Y6W03DNRTBOV@proxmox.com>
Subject: Re: [PATCH installer 4/8] sys: net: drop the now-unused `ipconf`
 runtime environment configuration
From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Hannes Laimer" <h.laimer@proxmox.com>
X-Mailer: aerc 0.21.0
References: <20260508184546.113293-1-c.heiss@proxmox.com>
 <20260508184546.113293-5-c.heiss@proxmox.com>
 <9afb6cab-e0eb-4b61-80b1-b38702f861b5@proxmox.com>
In-Reply-To: <9afb6cab-e0eb-4b61-80b1-b38702f861b5@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778493527048
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.076 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: FQY3BGJMPBVPEESU4S6JBO5TWRSBLODK
X-Message-ID-Hash: FQY3BGJMPBVPEESU4S6JBO5TWRSBLODK
X-MailFrom: c.heiss@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Thanks for the review!

On Mon May 11, 2026 at 10:55 AM CEST, Hannes Laimer wrote:
> `$run_env->{ipconfig}` is still accessed in `extract_data` (Install.pm)
> we should probably just use `$run_env->{network}->{interfaces}` like we
> do for pinning

Again good catch, thanks! If nothing else comes up, I'll send a v2
later.