public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function
@ 2026-04-21 12:12 Shan Shaji
  2026-04-29  7:58 ` Shan Shaji
  0 siblings, 1 reply; 2+ messages in thread
From: Shan Shaji @ 2026-04-21 12:12 UTC (permalink / raw)
  To: pve-devel

While placing the ACME certificate order using the Active24 plugin,
the request was failing [0]. This was because, `_json_decode` function
was referenced inside the dns_active24.sh file but was never defined
in the `proxmox-acme` script.To fix it, the missing function was added
by referencing the implementation from the acme.sh [1] script.

- [0] https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-json_decode-command-not-found.182899/
- [1] https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L912

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---

 **note**: I couldn't test the changes as i don't have Active24 credentials.
 
 src/proxmox-acme | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/proxmox-acme b/src/proxmox-acme
index 9eea590..499d533 100644
--- a/src/proxmox-acme
+++ b/src/proxmox-acme
@@ -913,6 +913,14 @@ _source_plugin_config() {
   return 0
 }
 
+# from: http:\/\/ to http://
+_json_decode() {
+  _j_str="$(sed 's#\\/#/#g')"
+  _debug3 "_json_decode"
+  _debug3 "_j_str" "$_j_str"
+  echo "$_j_str"
+}
+
 # Proxmox implementation to inject the DNSAPI variables
 _load_plugin_config() {
     while IFS= read -r line; do
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function
  2026-04-21 12:12 [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function Shan Shaji
@ 2026-04-29  7:58 ` Shan Shaji
  0 siblings, 0 replies; 2+ messages in thread
From: Shan Shaji @ 2026-04-29  7:58 UTC (permalink / raw)
  To: Shan Shaji, pve-devel

 update: user has confirmed that the fix works.

https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-json_decode-command-not-found.182899/post-849477

On Tue Apr 21, 2026 at 2:12 PM CEST, Shan Shaji wrote:
> While placing the ACME certificate order using the Active24 plugin,
> the request was failing [0]. This was because, `_json_decode` function
> was referenced inside the dns_active24.sh file but was never defined
> in the `proxmox-acme` script.To fix it, the missing function was added
> by referencing the implementation from the acme.sh [1] script.
>
> - [0] https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-json_decode-command-not-found.182899/
> - [1] https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L912
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
>  **note**: I couldn't test the changes as i don't have Active24 credentials.
>  
>  src/proxmox-acme | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/src/proxmox-acme b/src/proxmox-acme
> index 9eea590..499d533 100644
> --- a/src/proxmox-acme
> +++ b/src/proxmox-acme
> @@ -913,6 +913,14 @@ _source_plugin_config() {
>    return 0
>  }
>  
> +# from: http:\/\/ to http://
> +_json_decode() {
> +  _j_str="$(sed 's#\\/#/#g')"
> +  _debug3 "_json_decode"
> +  _debug3 "_j_str" "$_j_str"
> +  echo "$_j_str"
> +}
> +
>  # Proxmox implementation to inject the DNSAPI variables
>  _load_plugin_config() {
>      while IFS= read -r line; do





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-29  7:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-21 12:12 [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function Shan Shaji
2026-04-29  7:58 ` Shan Shaji

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal