From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7769A1FF142 for ; Tue, 21 Apr 2026 14:12:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5480521437; Tue, 21 Apr 2026 14:12:41 +0200 (CEST) From: Shan Shaji To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function Date: Tue, 21 Apr 2026 14:12:12 +0200 Message-ID: <20260421121212.218008-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776773469754 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.153 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UPWFBD5ELA3B4Y3AUSBHBXKRYKXEZSFW X-Message-ID-Hash: UPWFBD5ELA3B4Y3AUSBHBXKRYKXEZSFW X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: While placing the ACME certificate order using the Active24 plugin, the request was failing [0]. This was because, `_json_decode` function was referenced inside the dns_active24.sh file but was never defined in the `proxmox-acme` script.To fix it, the missing function was added by referencing the implementation from the acme.sh [1] script. - [0] https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-json_decode-command-not-found.182899/ - [1] https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L912 Signed-off-by: Shan Shaji --- **note**: I couldn't test the changes as i don't have Active24 credentials. src/proxmox-acme | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/proxmox-acme b/src/proxmox-acme index 9eea590..499d533 100644 --- a/src/proxmox-acme +++ b/src/proxmox-acme @@ -913,6 +913,14 @@ _source_plugin_config() { return 0 } +# from: http:\/\/ to http:// +_json_decode() { + _j_str="$(sed 's#\\/#/#g')" + _debug3 "_json_decode" + _debug3 "_j_str" "$_j_str" + echo "$_j_str" +} + # Proxmox implementation to inject the DNSAPI variables _load_plugin_config() { while IFS= read -r line; do -- 2.47.3