Re: [PATCH cluster/docs/manager v2 0/8] add warning messages for high token timeouts in clusters

["Lukas Sichert" <l.sichert@proxmox.com>]

I applied the patches and tested:

- a small selection of links using `onlineHelp` still work
- the new link using `get_help_link` jumps to the correct section
- the correct messages are displayed in the cluster and UI if the
  `token_coefficient` is high enough

One additional small nit not directly related to the changes in this
commit, but closely related: the documentation does not mention which
variable needs to be set for the token coefficient. While the name
`token_coefficient` is quite intuitive, I think it would still be good
to mention it explicitly, so one knows what to search for in the
manpages.

Since my comments are mostly minor, feel free to include my `Tested-by`
in v3.

Tested-by: Lukas Sichert <l.sichert@proxmox.com>

On 2026-04-20 18:43, Michael Köppl <m.koeppl@proxmox.com> wrote:

> This patch series introduces warnings informing users about high token
> timeouts in their clusters. A recent change [0] lowered the token
> coefficient for clusters and allowed adapting it. However, this change
> only affects new clusters. As described in [1], users with existing
> cluster should be informed about the high token timeouts in their
> configurations and what they can do to alleviate this problem.
>
> Thus, warnings are added to the `pvecm status` command as well as to the
> cluster join info dialog in the web UI. The warning in the web UI warns
> users about the effect adding another node would have to allow them to
> make an informed change before adding another node.
>
> changes since v1 (thanks to @Friedrich for the feedback on v1):
> - add pve-docs patch to allow using get_help_link to directly link to
>   an anchor in the local documentation (then used to link to the section
>   on changing the token coefficient)
> - add pve-docs patch to define explicit anchor for the "Changing the
>   Token Coefficient" section
> - add pve-docs patch extending the section for Changing the Token
>   Coefficient slightly, informing users of the potential warning
>   messages in the pvecm status output
> - change the threshold for "strongly recommend" from 50s to 45s as
>   suggested by @Friedrich
> - adapted the name of calculate_total_timeout to
>   calculate_membership_recovery_timeout
> - adapted commit messages for preparatory pve-manager patch (no
>   functional changes intended)
> - moved the warning message in pvecm from `pvecm nodes` to `pvecm status`
> - replaced the URL in the pvecm warning message with a reference to the
>   pvecm man pages
> - link to local documentation in ClusterEdit.js
>
> [0] https://git.proxmox.com/?p=pve-cluster.git;a=commit;h=a7b1c765b9223a81fb2dc4f072d6a6c095583cda
> [1] https://bugzilla.proxmox.com/show_bug.cgi?id=7398
>
> pve-docs:
>
> Michael Köppl (3):
>   asciidoc-pve: allow linking sections with get_help_link
>   pvecm: add explicit anchor for token coefficient section
>   pvecm: add info about warnings regarding token coefficient
>
>  pvecm.adoc              | 6 ++++++
>  scripts/asciidoc-pve.in | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
>
>
> pve-cluster:
>
> Michael Köppl (3):
>   add functions to determine warning level for high token timeouts
>   pvecm: warn users of high token timeouts when using status command
>   api: add token timeout and warning level to cluster join info
>
>  src/PVE/API2/ClusterConfig.pm | 22 +++++++++++++++
>  src/PVE/CLI/pvecm.pm          |  9 +++++++
>  src/PVE/Corosync.pm           | 50 +++++++++++++++++++++++++++++++++++
>  3 files changed, 81 insertions(+)
>
>
> pve-manager:
>
> Michael Köppl (2):
>   ui: cluster info: move initialization of items to initComponent
>   ui: cluster info: warn users of high token timeout in join info
>
>  www/manager6/dc/Cluster.js     |   4 +
>  www/manager6/dc/ClusterEdit.js | 141 ++++++++++++++++++++++-----------
>  2 files changed, 97 insertions(+), 48 deletions(-)
>
>
> Summary over all repositories:
>   7 files changed, 185 insertions(+), 49 deletions(-)
>
> -- 
> Generated by murpp 0.11.0