Re: [PATCH cluster v2 6/8] api: add token timeout and warning level to cluster join info

[Friedrich Weber <f.weber@proxmox.com>]

Thanks for the v2!

On 20/04/2026 18:42, Michael Köppl wrote:
> The token timeout in seconds and the warning level provide additional
> information for users regarding the expected token timeout in seconds
> after adding an additional node and whether changing the token
> coefficient is recommended.
> 
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
>  src/PVE/API2/ClusterConfig.pm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/src/PVE/API2/ClusterConfig.pm b/src/PVE/API2/ClusterConfig.pm
> index bbed40e..5739e4c 100644
> --- a/src/PVE/API2/ClusterConfig.pm
> +++ b/src/PVE/API2/ClusterConfig.pm
> @@ -571,6 +571,18 @@ __PACKAGE__->register_method({
>              preferred_node => get_standard_option('pve-node'),
>              totem => { type => 'object' },
>              config_digest => { type => 'string' },
> +            expected_timeout => {
> +                type => 'number',
> +                description =>
> +                    "Expected total timeout (in seconds) if an additional node is added.",
> +                optional => 1,
> +            },
> +            timeout_warning_level => {
> +                type => 'string',
> +                description => "Warning level for the expected total timeout.",
> +                optional => 1,
> +                enum => ['optimize', 'change-recommended', 'change-strongly-recommended'],
> +            },
>          },

IMO it would be good to clarify the broad "timeout" term also here
(since it's part of the public API). But do I realize that
"expected_membership_recovery_timeout" is very long. (I guess
"timeout_warning_level" is probably fine) Maybe someone who has a better
overview over our API design can chime in?

>      },
>      code => sub {
> @@ -599,12 +611,22 @@ __PACKAGE__->register_method({
>              $node->{pve_addr} = scalar(PVE::Cluster::remote_node_ip($name));
>          }
>  
> +        # Total timeout if additional node is added
> +        my $total_timeout_secs = PVE::Corosync::calculate_membership_recovery_timeout(
> +            $totem_cfg,
> +            scalar(keys %$nodelist) + 1,
> +        );
> +
> +        my $warning_level = PVE::Corosync::get_timeout_warning_level($total_timeout_secs);
> +
>          my $res = {
>              nodelist => [values %$nodelist],
>              preferred_node => $nodename,
>              totem => $totem_cfg,
>              config_digest => $corosync_config_digest,
> +            expected_timeout => $total_timeout_secs,
>          };
> +        $res->{timeout_warning_level} = $warning_level if defined($warning_level);
>  
>          return $res;
>      },