From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7E01C1FF142 for ; Tue, 21 Apr 2026 09:21:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C631161F7; Tue, 21 Apr 2026 09:21:35 +0200 (CEST) Message-ID: <1b7c1d79-8524-4da8-89d4-ee91a236ec8b@proxmox.com> Date: Tue, 21 Apr 2026 09:20:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH cluster v2 6/8] api: add token timeout and warning level to cluster join info To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20260420164314.370023-1-m.koeppl@proxmox.com> <20260420164314.370023-7-m.koeppl@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20260420164314.370023-7-m.koeppl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776755974753 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [clusterconfig.pm] Message-ID-Hash: QU3VIUJK3T6FFOM34EOF6S6WUZTBSRLN X-Message-ID-Hash: QU3VIUJK3T6FFOM34EOF6S6WUZTBSRLN X-MailFrom: f.weber@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the v2! On 20/04/2026 18:42, Michael Köppl wrote: > The token timeout in seconds and the warning level provide additional > information for users regarding the expected token timeout in seconds > after adding an additional node and whether changing the token > coefficient is recommended. > > Signed-off-by: Michael Köppl > --- > src/PVE/API2/ClusterConfig.pm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/src/PVE/API2/ClusterConfig.pm b/src/PVE/API2/ClusterConfig.pm > index bbed40e..5739e4c 100644 > --- a/src/PVE/API2/ClusterConfig.pm > +++ b/src/PVE/API2/ClusterConfig.pm > @@ -571,6 +571,18 @@ __PACKAGE__->register_method({ > preferred_node => get_standard_option('pve-node'), > totem => { type => 'object' }, > config_digest => { type => 'string' }, > + expected_timeout => { > + type => 'number', > + description => > + "Expected total timeout (in seconds) if an additional node is added.", > + optional => 1, > + }, > + timeout_warning_level => { > + type => 'string', > + description => "Warning level for the expected total timeout.", > + optional => 1, > + enum => ['optimize', 'change-recommended', 'change-strongly-recommended'], > + }, > }, IMO it would be good to clarify the broad "timeout" term also here (since it's part of the public API). But do I realize that "expected_membership_recovery_timeout" is very long. (I guess "timeout_warning_level" is probably fine) Maybe someone who has a better overview over our API design can chime in? > }, > code => sub { > @@ -599,12 +611,22 @@ __PACKAGE__->register_method({ > $node->{pve_addr} = scalar(PVE::Cluster::remote_node_ip($name)); > } > > + # Total timeout if additional node is added > + my $total_timeout_secs = PVE::Corosync::calculate_membership_recovery_timeout( > + $totem_cfg, > + scalar(keys %$nodelist) + 1, > + ); > + > + my $warning_level = PVE::Corosync::get_timeout_warning_level($total_timeout_secs); > + > my $res = { > nodelist => [values %$nodelist], > preferred_node => $nodename, > totem => $totem_cfg, > config_digest => $corosync_config_digest, > + expected_timeout => $total_timeout_secs, > }; > + $res->{timeout_warning_level} = $warning_level if defined($warning_level); > > return $res; > },