Re: [PATCH cluster v2 4/8] add functions to determine warning level for high token timeouts

["Michael Köppl" <m.koeppl@proxmox.com>]

On Mon Apr 20, 2026 at 6:43 PM CEST, Michael Köppl wrote:

[snip]

> +sub calculate_membership_recovery_timeout {
> +    my ($totemcfg, $node_count) = @_;
> +
> +    my $token_timeout = $totemcfg->{token} // 3000;
> +    my $token_coefficient = $totemcfg->{token_coefficient} // 650;
> +
> +    my $expected_token_timeout = $token_timeout;
> +    if ($node_count > 2) {
> +        $expected_token_timeout += ($node_count - 2) * $token_coefficient;
> +    }
> +
> +    my $expected_consensus_timeout = $totemcfg->{consensus} // $expected_token_timeout * 1.2;
> +    return ($expected_token_timeout + $expected_consensus_timeout) / 1000.0;
> +}
> +
> +sub get_timeout_warning_level {

just noticed that it probably makes sense to also rename this function
to `get_membership_recovery_timeout_warning_level`. Don't like the long
name, but it makes it clearer which timeout this is about.

> +    my ($total_timeout_secs) = @_;
> +
> +    if ($total_timeout_secs > 45) {
> +        return 'change-strongly-recommended';
> +    } elsif ($total_timeout_secs > 40) {
> +        return 'change-recommended';
> +    } elsif ($total_timeout_secs > 30) {
> +        return 'optimize';
> +    }
> +
> +    return undef;
> +}
> +
> +sub get_timeout_warning {

same as above, but as `get_membership_recovery_timeout_warning`.

> +    my ($total_timeout_secs) = @_;
> +
> +    my $level = get_timeout_warning_level($total_timeout_secs);
> +    return undef if !defined($level);
> +
> +    my $level_msg;
> +    if ($level eq 'change-strongly-recommended') {
> +        $level_msg = "Changing the token coefficient is strongly recommended";

[snip]