public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH cluster 1/9] datacenter config: add token-policy option
Date: Tue, 10 Nov 2026 17:00:37 +0100	[thread overview]
Message-ID: <9ba3ed4c-ccc8-43cf-98f1-46feae06f33a@proxmox.com> (raw)
In-Reply-To: <DMRMGFI620H5.27V9QXMTG0SPK@proxmox.com>

Am 10.11.26 um 16:05 schrieb Shannon Sterz:
>> +    'disallow-expiry-changes' => {
>> +        type => 'boolean',
>> +        optional => 1,
>> +        default => 0,
>> +        description => "Disallow changing the expiration date of existing API tokens, so that"
>> +            . " 'max-lifetime' cannot be circumvented by extending tokens repeatedly. Such"
>> +            . " tokens can still be deleted and recreated.",
> currently this also seems to disallow setting an expiry for old tokens
> or shortening the lifetime of an existing token with a pre-existing
> expiry. while this may be intentional, id argue this makes compliance
> less convenient to achieve.
> 
> auditors may want an admin to set an expiry asap on a token without one.
> this option would allow only removing the old token and creating a new
> one as an option. creating a new token with specific permissions may be
> cumbersome.
> 
> since there is no downside to shortening a token lifetime, im not sure
> what the value here is. especially if we do decide to allow lifetime
> extensions by secret regeneration.
> 
> the rational here also only talks about avoid lifetime extension, so at
> the very least it should maybe also mention why lifetime shortening is
> also disallowed.

Yeah allowing shortening of live-time would be fine.

Not directly related, but wondering about a general flags for
"allow new token creation" and "allow token usage" as sort of emergency
stop for containment. But if, then something for its own series.




  reply	other threads:[~2026-11-10 16:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 20:59 [PATCH cluster/access-control/manager/docs/proxmox 0/9] fix #7805: add a datacenter-wide API token policy Thomas Lamprecht
2026-09-23 20:59 ` [PATCH cluster 1/9] datacenter config: add token-policy option Thomas Lamprecht
2026-11-10 15:05   ` Shannon Sterz
2026-11-10 16:00     ` Thomas Lamprecht [this message]
2026-09-23 20:59 ` [PATCH access-control 2/9] fix #7805: api: token: enforce datacenter token policy Thomas Lamprecht
2026-09-23 20:59 ` [PATCH docs 3/9] user management: document the API " Thomas Lamprecht
2026-11-10 15:05   ` Shannon Sterz
2026-09-23 20:59 ` [PATCH manager 4/9] ui: token edit: only submit the expiration date when changed Thomas Lamprecht
2026-09-23 20:59 ` [PATCH manager 5/9] api: cluster options: return token-policy without Sys.Audit Thomas Lamprecht
2026-09-23 20:59 ` [PATCH manager 6/9] ui: dc options: allow editing the API token policy Thomas Lamprecht
2026-11-10 15:05   ` Shannon Sterz
2026-09-23 20:59 ` [PATCH manager 7/9] ui: token edit: adapt to the datacenter " Thomas Lamprecht
2026-09-23 20:59 ` [PATCH proxmox 8/9] access-control: add API token policy type with expiry checks Thomas Lamprecht
2026-11-10 15:05   ` Shannon Sterz
2026-09-23 20:59 ` [PATCH proxmox 9/9] access-control: enforce token policy on token create and update Thomas Lamprecht
2026-11-10 15:04   ` Shannon Sterz
2026-11-10 15:05 ` [PATCH cluster/access-control/manager/docs/proxmox 0/9] fix #7805: add a datacenter-wide API token policy Shannon Sterz
2026-11-10 15:28   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ba3ed4c-ccc8-43cf-98f1-46feae06f33a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal