[PATCH manager 4/9] ui: token edit: only submit the expiration date when changed

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

The day-granular date field resubmits the stored expiration date
truncated to the start of its day, so any unrelated edit, for example
of the comment, silently shortened the stored date by up to a day.
Drop the value from the submission if the selected day was not
actually changed.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 www/manager6/dc/TokenEdit.js | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/www/manager6/dc/TokenEdit.js b/www/manager6/dc/TokenEdit.js
index fc9f0cc2c..2baeb5b74 100644
--- a/www/manager6/dc/TokenEdit.js
+++ b/www/manager6/dc/TokenEdit.js
@@ -25,6 +25,21 @@ Ext.define('PVE.dc.TokenEdit', {
             delete values.userid;
             delete values.tokenid;
 
+            // the day-granular date field resubmits the expiration date truncated to the
+            // start of its day, drop it if the selected day was not actually changed to
+            // avoid silently shortening the stored date on unrelated edits
+            if (!win.isCreate && win.originalExpire !== undefined) {
+                let sameDay = 0;
+                if (win.originalExpire) {
+                    let day = new Date(win.originalExpire * 1000);
+                    day.setHours(0, 0, 0, 0);
+                    sameDay = Math.floor(day.getTime() / 1000);
+                }
+                if (Number(values.expire) === sameDay) {
+                    delete values.expire;
+                }
+            }
+
             win.url += `${uid}/token/${tid}`;
             return values;
         },
@@ -91,6 +106,20 @@ Ext.define('PVE.dc.TokenEdit', {
             });
         }
     },
+
+    setValues: function (values) {
+        let me = this;
+        // remember the stored expiration date to detect a real change on submission; the
+        // token grid's record carries it as a Date object, the API as epoch seconds
+        if (!me.isCreate && values.expire !== undefined) {
+            me.originalExpire =
+                values.expire instanceof Date
+                    ? Math.floor(values.expire.getTime() / 1000)
+                    : Number(values.expire);
+        }
+        me.callParent([values]);
+    },
+
     apiCallDone: function (success, response, options) {
         let res = response.result.data;
         if (!success || !res.value) {
-- 
2.47.3