Re: [PATCH pve-manager v2 14/17] api: add API routes 'plugins' and 'plugins/storage'

[Jakob Klocker <j.klocker@proxmox.com>]

comment inline

On 7/17/26 5:51 PM, Max R. Carrara wrote:
> Add the `plugins` route to our API and handle it via its own module,
> `API2/Plugins.pm`. Implement a GET endpoint for this route, which just
> lists its subpaths.
> 
> Additionally, add the `plugins/storage` path to the API and let all
> corresponding endpoints be handled by the
> `PVE::API2::Plugins::Storage` module, which is part of the
> `libpve-storage-perl` package.
> 
> This means that the following routes are now available:
> * plugins
> * plugins/storage
> * plugins/storage/plugin
> * plugins/storage/plugin/{type}
> 
> Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
> ---
>  PVE/API2.pm         |  6 +++++
>  PVE/API2/Makefile   |  1 +
>  PVE/API2/Plugins.pm | 61 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 68 insertions(+)
>  create mode 100644 PVE/API2/Plugins.pm
> 
> diff --git a/PVE/API2.pm b/PVE/API2.pm
> index 0c7e4654..af1cf38b 100644
> --- a/PVE/API2.pm
> +++ b/PVE/API2.pm
> @@ -17,6 +17,7 @@ use PVE::API2::Nodes;
>  use PVE::API2::Pool;
>  use PVE::API2::AccessControl;
>  use PVE::API2::Storage::Config;
> +use PVE::API2::Plugins;
>  

style-nit: modules aren't sorted alphabetically

>  __PACKAGE__->register_method({
>      subclass => "PVE::API2::Cluster",
> @@ -43,6 +44,11 @@ __PACKAGE__->register_method({
>      path => 'pools',
>  });
>  
> +__PACKAGE__->register_method({
> +    subclass => "PVE::API2::Plugins",
> +    path => 'plugins',
> +});
> +
>  __PACKAGE__->register_method({
>      name => 'index',
>      path => '',
> diff --git a/PVE/API2/Makefile b/PVE/API2/Makefile
> index 97f1cc20..97910009 100644
> --- a/PVE/API2/Makefile
> +++ b/PVE/API2/Makefile
> @@ -17,6 +17,7 @@ PERLSOURCE = 			\
>  	Network.pm		\
>  	NodeConfig.pm		\
>  	Nodes.pm		\
> +	Plugins.pm		\
>  	Pool.pm			\
>  	Replication.pm		\
>  	ReplicationConfig.pm	\
> diff --git a/PVE/API2/Plugins.pm b/PVE/API2/Plugins.pm
> new file mode 100644
> index 00000000..beb606e6
> --- /dev/null
> +++ b/PVE/API2/Plugins.pm
> @@ -0,0 +1,61 @@
> +package PVE::API2::Plugins;
[snip]