From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 0495F1FF138 for ; Mon, 20 Jul 2026 14:26:54 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 72331214AB; Mon, 20 Jul 2026 14:26:53 +0200 (CEST) Message-ID: <92ff899e-cbe3-4fd3-bf18-19d66e69c6d0@proxmox.com> Date: Mon, 20 Jul 2026 14:26:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pve-manager v2 14/17] api: add API routes 'plugins' and 'plugins/storage' To: "Max R. Carrara" , pve-devel@lists.proxmox.com References: <20260717154943.696411-1-m.carrara@proxmox.com> <20260717154943.696411-15-m.carrara@proxmox.com> Content-Language: en-US From: Jakob Klocker In-Reply-To: <20260717154943.696411-15-m.carrara@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784550354378 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.930 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PYR2FTW4ZNKHBT7OW5B374HZWY3TKA6F X-Message-ID-Hash: PYR2FTW4ZNKHBT7OW5B374HZWY3TKA6F X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: comment inline On 7/17/26 5:51 PM, Max R. Carrara wrote: > Add the `plugins` route to our API and handle it via its own module, > `API2/Plugins.pm`. Implement a GET endpoint for this route, which just > lists its subpaths. > > Additionally, add the `plugins/storage` path to the API and let all > corresponding endpoints be handled by the > `PVE::API2::Plugins::Storage` module, which is part of the > `libpve-storage-perl` package. > > This means that the following routes are now available: > * plugins > * plugins/storage > * plugins/storage/plugin > * plugins/storage/plugin/{type} > > Signed-off-by: Max R. Carrara > --- > PVE/API2.pm | 6 +++++ > PVE/API2/Makefile | 1 + > PVE/API2/Plugins.pm | 61 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 68 insertions(+) > create mode 100644 PVE/API2/Plugins.pm > > diff --git a/PVE/API2.pm b/PVE/API2.pm > index 0c7e4654..af1cf38b 100644 > --- a/PVE/API2.pm > +++ b/PVE/API2.pm > @@ -17,6 +17,7 @@ use PVE::API2::Nodes; > use PVE::API2::Pool; > use PVE::API2::AccessControl; > use PVE::API2::Storage::Config; > +use PVE::API2::Plugins; > style-nit: modules aren't sorted alphabetically > __PACKAGE__->register_method({ > subclass => "PVE::API2::Cluster", > @@ -43,6 +44,11 @@ __PACKAGE__->register_method({ > path => 'pools', > }); > > +__PACKAGE__->register_method({ > + subclass => "PVE::API2::Plugins", > + path => 'plugins', > +}); > + > __PACKAGE__->register_method({ > name => 'index', > path => '', > diff --git a/PVE/API2/Makefile b/PVE/API2/Makefile > index 97f1cc20..97910009 100644 > --- a/PVE/API2/Makefile > +++ b/PVE/API2/Makefile > @@ -17,6 +17,7 @@ PERLSOURCE = \ > Network.pm \ > NodeConfig.pm \ > Nodes.pm \ > + Plugins.pm \ > Pool.pm \ > Replication.pm \ > ReplicationConfig.pm \ > diff --git a/PVE/API2/Plugins.pm b/PVE/API2/Plugins.pm > new file mode 100644 > index 00000000..beb606e6 > --- /dev/null > +++ b/PVE/API2/Plugins.pm > @@ -0,0 +1,61 @@ > +package PVE::API2::Plugins; [snip]