public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC pve-storage v2 10/17] plugin, dirplugin: mark certain properties as hidden
Date: Fri, 17 Jul 2026 17:49:17 +0200	[thread overview]
Message-ID: <20260717154943.696411-11-m.carrara@proxmox.com> (raw)
In-Reply-To: <20260717154943.696411-1-m.carrara@proxmox.com>

Add a new 'x-hidden' keyword to the 'bwlimit', 'create-base-path',
'content-dirs', 'create-subdirs' and 'format' properties. This keyword
will act as a hint in the UI to not include the fields corresponding
to these properties in the storage config create / edit panel at all.

Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
NOTE: This patch is experimental and thus marked as RFC.

 src/PVE/Storage/DirPlugin.pm | 10 +++++++++-
 src/PVE/Storage/Plugin.pm    |  2 ++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Storage/DirPlugin.pm b/src/PVE/Storage/DirPlugin.pm
index cc52feae..9c98ebed 100644
--- a/src/PVE/Storage/DirPlugin.pm
+++ b/src/PVE/Storage/DirPlugin.pm
@@ -63,12 +63,14 @@ sub properties {
             description => "Create the base directory if it doesn't exist.",
             type => 'boolean',
             default => 'yes',
+            'x-hidden' => 1,
         },
         'create-subdirs' => {
             title => "Populate Base Directory",
             description => "Populate the base directory with the default structure.",
             type => 'boolean',
             default => 'yes',
+            'x-hidden' => 1,
         },
         is_mountpoint => {
             title => "Is Mountpoint",
@@ -78,7 +80,13 @@ sub properties {
             type => 'string',
             default => 'no',
         },
-        bwlimit => get_standard_option('bwlimit', { title => "Bandwidth Limit" }),
+        bwlimit => get_standard_option(
+            'bwlimit',
+            {
+                title => "Bandwidth Limit",
+                'x-hidden' => 1,
+            },
+        ),
     };
 }

diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index a9776240..c5fab9ef 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -230,6 +230,7 @@ my $defaultData = {
                 title => "Default Format",
                 description => "Default image format.",
                 optional => 1,
+                'x-hidden' => 1,
             },
         ),
         preallocation => {
@@ -248,6 +249,7 @@ my $defaultData = {
             type => "string",
             format => "pve-dir-override-list",
             optional => 1,
+            'x-hidden' => 1,
         },
         options => {
             title => "Mount Options",
--
2.47.3





  parent reply	other threads:[~2026-07-17 15:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 15:49 [PATCH common/manager/proxmox-widget-toolkit/storage v2 00/17] GUI Support for Custom Storage Plugins Max R. Carrara
2026-07-17 15:49 ` [PATCH pve-common v2 01/17] json schema: add multiline string format Max R. Carrara
2026-07-17 15:49 ` [RFC pve-common v2 02/17] jsonschema: support 'patternProperties' and allow 'x-' keywords Max R. Carrara
2026-07-20 12:01   ` Jakob Klocker
2026-07-17 15:49 ` [PATCH pve-storage v2 03/17] api: plugins/storage: add initial routes and endpoints Max R. Carrara
2026-07-20 12:17   ` Jakob Klocker
2026-07-20 12:21   ` Jakob Klocker
2026-07-17 15:49 ` [PATCH pve-storage v2 04/17] api: plugins/storage/plugin: include schema in plugin metadata Max R. Carrara
2026-07-17 15:49 ` [PATCH pve-storage v2 05/17] api: plugins/storage/plugin: mark sensitive properties in schema Max R. Carrara
2026-07-17 15:49 ` [PATCH pve-storage v2 06/17] api: plugins/storage/plugin: factor plugin metadata code into helper Max R. Carrara
2026-07-17 15:49 ` [PATCH pve-storage v2 07/17] api: plugins/storage/plugin: add plugins' 'content' to their metadata Max R. Carrara
2026-07-17 15:49 ` [PATCH pve-storage v2 08/17] all plugins: add 'title' to properties, adapt 'description's Max R. Carrara
2026-07-17 15:49 ` [RFC pve-storage v2 09/17] plugin: mark 'preallocation' and 'content-dirs' properties as advanced Max R. Carrara
2026-07-17 15:49 ` Max R. Carrara [this message]
2026-07-17 15:49 ` [PATCH proxmox-widget-toolkit v2 11/17] form: introduce new 'proxmoxtextarea' field Max R. Carrara
2026-07-17 15:49 ` [PATCH proxmox-widget-toolkit v2 12/17] utils: introduce helper function getFieldDefFromPropertySchema Max R. Carrara
2026-07-17 15:49 ` [PATCH proxmox-widget-toolkit v2 13/17] acme: use helper to construct ExtJS fields from property schemas Max R. Carrara
2026-07-17 15:49 ` [PATCH pve-manager v2 14/17] api: add API routes 'plugins' and 'plugins/storage' Max R. Carrara
2026-07-20 12:26   ` Jakob Klocker
2026-07-17 15:49 ` [PATCH pve-manager v2 15/17] ui: storage view: display error when no editor for storage type exists Max R. Carrara
2026-07-17 15:49 ` [PATCH pve-manager v2 16/17] ui: storage: add basic UI integration for custom storage plugins Max R. Carrara
2026-07-17 15:49 ` [RFC pve-manager v2 17/17] ui: storage: use property extension keywords for UI hints Max R. Carrara
2026-07-18 18:19 ` [PATCH common/manager/proxmox-widget-toolkit/storage v2 00/17] GUI Support for Custom Storage Plugins Ciro Iriarte
2026-07-21  9:24   ` Max R. Carrara
2026-07-20 12:48 ` Jakob Klocker
2026-07-21  9:09   ` Max R. Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717154943.696411-11-m.carrara@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal