From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 532751FF129 for ; Fri, 17 Jul 2026 17:51:28 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6B1862141C; Fri, 17 Jul 2026 17:50:39 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [RFC pve-storage v2 10/17] plugin, dirplugin: mark certain properties as hidden Date: Fri, 17 Jul 2026 17:49:17 +0200 Message-ID: <20260717154943.696411-11-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260717154943.696411-1-m.carrara@proxmox.com> References: <20260717154943.696411-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784303383367 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GZWFWL3BFA7UIWQQ2DJOQAFVLGWY3BIZ X-Message-ID-Hash: GZWFWL3BFA7UIWQQ2DJOQAFVLGWY3BIZ X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add a new 'x-hidden' keyword to the 'bwlimit', 'create-base-path', 'content-dirs', 'create-subdirs' and 'format' properties. This keyword will act as a hint in the UI to not include the fields corresponding to these properties in the storage config create / edit panel at all. Signed-off-by: Max R. Carrara --- NOTE: This patch is experimental and thus marked as RFC. src/PVE/Storage/DirPlugin.pm | 10 +++++++++- src/PVE/Storage/Plugin.pm | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/DirPlugin.pm b/src/PVE/Storage/DirPlugin.pm index cc52feae..9c98ebed 100644 --- a/src/PVE/Storage/DirPlugin.pm +++ b/src/PVE/Storage/DirPlugin.pm @@ -63,12 +63,14 @@ sub properties { description => "Create the base directory if it doesn't exist.", type => 'boolean', default => 'yes', + 'x-hidden' => 1, }, 'create-subdirs' => { title => "Populate Base Directory", description => "Populate the base directory with the default structure.", type => 'boolean', default => 'yes', + 'x-hidden' => 1, }, is_mountpoint => { title => "Is Mountpoint", @@ -78,7 +80,13 @@ sub properties { type => 'string', default => 'no', }, - bwlimit => get_standard_option('bwlimit', { title => "Bandwidth Limit" }), + bwlimit => get_standard_option( + 'bwlimit', + { + title => "Bandwidth Limit", + 'x-hidden' => 1, + }, + ), }; } diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index a9776240..c5fab9ef 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -230,6 +230,7 @@ my $defaultData = { title => "Default Format", description => "Default image format.", optional => 1, + 'x-hidden' => 1, }, ), preallocation => { @@ -248,6 +249,7 @@ my $defaultData = { type => "string", format => "pve-dir-override-list", optional => 1, + 'x-hidden' => 1, }, options => { title => "Mount Options", -- 2.47.3