public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v6 17/26] api: migrate: allow forwarding certain migration properties to HA
Date: Thu, 12 Nov 2026 10:21:53 +0100	[thread overview]
Message-ID: <924d0562-fc3d-44f3-8988-497eabc50021@proxmox.com> (raw)
In-Reply-To: <DMSHTU1NTEGX.95M02EYIRIB@proxmox.com>

Am 11.11.26 um 4:40 PM schrieb Michael Köppl:
> On Tue Nov 3, 2026 at 1:48 PM CET, Fiona Ebner wrote:
>> -        },
>> +        properties => $migrate_json_properties,
>>      },
>>      returns => {
>>          type => 'string',
>> @@ -5702,9 +5713,20 @@ __PACKAGE__->register_method({
>>              my $hacmd = sub {
>>                  my $upid = shift;
>>
>> -                print "Requesting HA migration for VM $vmid to node $target\n";
>> -
>> +                my $extra_opts = '';
>>                  my $cmd = ['ha-manager', 'migrate', "vm:$vmid", $target];
>> +                for my $prop (sort keys $ha_migrate_props->%*) {
>> +                    if (defined(my $value = $param->{$prop})) {
>> +                        push($cmd->@*, "--$prop", $value);
>> +                        $extra_opts .= ', ' if $extra_opts;
>> +                        $extra_opts .= "$prop=$value";
>> +                    }
>> +                }
> 
> Only tangentially related, but because I noticed that this came up
> previously [0]: when migrating a *stopped* VM through the GUI,
> the checkbox for 'with-conntrack-state' is hidden, but the dialog still
> sends 'with-conntrack-state: 1', which migrate_vm then overrides with 0
> again.  The task log then shows "(with-conntrack-state=0)" and the CRM
> receives command
> `migrate vm:100 pve2-ceph {"with-conntrack-state":"0"}`. To me, this
> looks like a purely cosmetic issue, though, and I'm not sure it's worth
> changing how params are forwarded here.
> 
> [0] https://lore.proxmox.com/pve-devel/8c0157e4-e8a9-4ed8-8d08-98ed82f18a0e@proxmox.com/
Ah, so maybe that is what Daniel meant ;) What I wrote in my reply there
is that it is not set if the checkbox is unchecked (but for an offline
migration the UI doesn't let you uncheck it :P). I'll add a patch to fix
this where the property is overwritten for the offline case, not here.




  reply	other threads:[~2026-11-12  9:22 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 12:47 [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration Fiona Ebner
2026-11-03 12:47 ` [PATCH common v6 01/26] rest handler: handle: respect schema's 'type-property' when resolving type Fiona Ebner
2026-11-03 12:47 ` [PATCH cluster v6 02/26] cluster: add more convenience helpers for checking node versions Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 03/26] manager: add missing PVE::HA::Resources import Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 04/26] update crm commands: align logging with next state started/stopped Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 05/26] manager: factor out helper to check if requested resource motion is valid Fiona Ebner
2026-11-11 15:39   ` Michael Köppl
2026-11-12 11:00     ` Thomas Lamprecht
2026-11-12 11:07       ` Fiona Ebner
2026-11-12 11:21         ` Thomas Lamprecht
2026-11-12 11:52           ` Fiona Ebner
2026-11-12 12:23           ` Michael Köppl
2026-11-12 15:35             ` Thomas Lamprecht
2026-11-03 12:47 ` [PATCH ha-manager v6 06/26] next state stopped: align logging for motion command with next_state_started() Fiona Ebner
2026-11-11 15:39   ` Michael Köppl
2026-11-03 12:47 ` [PATCH ha-manager v6 07/26] next state {stopped,started}: factor out helper to handle motion command Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 08/26] lrm: resource migration: support extra migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 09/26] change service state: support hash as a parameter value Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 10/26] next state: handle motion command: support migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 11/26] resources: add migrate_json_properties() method Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 12/26] queue resource motion: support migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 13/26] crm command: support JSON-style migrate command Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 14/26] api: resources: migration: support additional migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 15/26] test: add test for " Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 16/26] helpers: move get_node_pvecfg_version() version helper to pve-cluster Fiona Ebner
2026-11-11 15:39   ` Michael Köppl
2026-11-03 12:48 ` [PATCH qemu-server v6 17/26] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-11-11 15:40   ` Michael Köppl
2026-11-12  9:21     ` Fiona Ebner [this message]
2026-11-03 12:48 ` [PATCH qemu-server v6 18/26] fix #7053: api: migrate: pass 'with-conntrack-state' flag to HA migration Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 19/26] qm: mtunnel: reply when a command is unknown Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 20/26] qm: mtunnel: add 'conf' command to do strict configuration parsing Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 21/26] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-11-11 15:40   ` Michael Köppl
2026-11-12  9:38     ` Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 22/26] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 23/26] pct: introduce mtunnel command Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 24/26] d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 25/26] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-11-11 15:41   ` Michael Köppl
2026-11-12 10:50     ` Fiona Ebner
2026-11-03 12:48 ` [PATCH manager v6 26/26] ui: migrate: add checkbox to allow skipping newly enforced config check Fiona Ebner
2026-11-08 23:35 ` applied: (subset) [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration Thomas Lamprecht
2026-11-11 15:41 ` Michael Köppl
2026-11-11 15:51   ` Michael Köppl
2026-11-12 10:51   ` Fiona Ebner
2026-11-12 11:54 ` superseded: " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=924d0562-fc3d-44f3-8988-497eabc50021@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal