From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>,
"Fiona Ebner" <f.ebner@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH ha-manager v6 05/26] manager: factor out helper to check if requested resource motion is valid
Date: Thu, 12 Nov 2026 16:35:36 +0100 [thread overview]
Message-ID: <0e91623a-102f-4266-8a92-209ce001d8b9@proxmox.com> (raw)
In-Reply-To: <DMT89WO3CBTI.UJY6ELAY7TJW@proxmox.com>
Am 12.11.26 um 13:23 schrieb Michael Köppl:
> On Thu Nov 12, 2026 at 12:21 PM CET, Thomas Lamprecht wrote:
>> Am 12.11.26 um 12:08 schrieb Fiona Ebner:
>>> I would prefer a limit higher than 72. It can be quite useful for git
>>> oneline log if there is more context (prefixes), and more specific
>>> commit subjects.
>>
>> Alright, thanks for your input, so increasing is settled. What would be
>> your preferred guideline:
>>
>> 1. subject should be below 80cc and must be below 120cc, body still 72cc
>>
>> 2. subject should be below 100cc and must be below 120cc, body still 72c
>>
>> 3. subject should be below 80cc and must be below 100cc, body still 72cc
>>
>> 4. One of the above (which one) but unified also for the whole message
>> (body and subject).
>
> I agree with Fiona. 3 looks like a sensible solution to me as well.
> Thanks for bringing this up in any case. This should make it easier to
> adhere to the rule without being overly restrictive.
Ack, thanks to both of you for your input. I amended our developer docs
with that:
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
next prev parent reply other threads:[~2026-11-12 15:35 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 12:47 [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration Fiona Ebner
2026-11-03 12:47 ` [PATCH common v6 01/26] rest handler: handle: respect schema's 'type-property' when resolving type Fiona Ebner
2026-11-03 12:47 ` [PATCH cluster v6 02/26] cluster: add more convenience helpers for checking node versions Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 03/26] manager: add missing PVE::HA::Resources import Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 04/26] update crm commands: align logging with next state started/stopped Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 05/26] manager: factor out helper to check if requested resource motion is valid Fiona Ebner
2026-11-11 15:39 ` Michael Köppl
2026-11-12 11:00 ` Thomas Lamprecht
2026-11-12 11:07 ` Fiona Ebner
2026-11-12 11:21 ` Thomas Lamprecht
2026-11-12 11:52 ` Fiona Ebner
2026-11-12 12:23 ` Michael Köppl
2026-11-12 15:35 ` Thomas Lamprecht [this message]
2026-11-03 12:47 ` [PATCH ha-manager v6 06/26] next state stopped: align logging for motion command with next_state_started() Fiona Ebner
2026-11-11 15:39 ` Michael Köppl
2026-11-03 12:47 ` [PATCH ha-manager v6 07/26] next state {stopped,started}: factor out helper to handle motion command Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 08/26] lrm: resource migration: support extra migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 09/26] change service state: support hash as a parameter value Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 10/26] next state: handle motion command: support migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 11/26] resources: add migrate_json_properties() method Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 12/26] queue resource motion: support migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 13/26] crm command: support JSON-style migrate command Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 14/26] api: resources: migration: support additional migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 15/26] test: add test for " Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 16/26] helpers: move get_node_pvecfg_version() version helper to pve-cluster Fiona Ebner
2026-11-11 15:39 ` Michael Köppl
2026-11-03 12:48 ` [PATCH qemu-server v6 17/26] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-11-11 15:40 ` Michael Köppl
2026-11-12 9:21 ` Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 18/26] fix #7053: api: migrate: pass 'with-conntrack-state' flag to HA migration Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 19/26] qm: mtunnel: reply when a command is unknown Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 20/26] qm: mtunnel: add 'conf' command to do strict configuration parsing Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 21/26] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-11-11 15:40 ` Michael Köppl
2026-11-12 9:38 ` Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 22/26] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 23/26] pct: introduce mtunnel command Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 24/26] d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 25/26] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-11-11 15:41 ` Michael Köppl
2026-11-12 10:50 ` Fiona Ebner
2026-11-03 12:48 ` [PATCH manager v6 26/26] ui: migrate: add checkbox to allow skipping newly enforced config check Fiona Ebner
2026-11-08 23:35 ` applied: (subset) [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration Thomas Lamprecht
2026-11-11 15:41 ` Michael Köppl
2026-11-11 15:51 ` Michael Köppl
2026-11-12 10:51 ` Fiona Ebner
2026-11-12 11:54 ` superseded: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e91623a-102f-4266-8a92-209ce001d8b9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox