From: Fiona Ebner <f.ebner@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration
Date: Thu, 12 Nov 2026 11:51:32 +0100 [thread overview]
Message-ID: <01d620c9-d9e2-4ac5-9874-49252e6a6949@proxmox.com> (raw)
In-Reply-To: <DMSHUQ3K3G9M.6F4VZJ1IF8Y@proxmox.com>
Am 11.11.26 um 4:41 PM schrieb Michael Köppl:
> Tested this series on a 3-node cluster:
> - Introduced a new config option for both VMs and CTs on node A (so
> it's considered valid there), then set the option for VM 100 and
> attempted to migrate to node B. Checked that the migration was
> rejected and that the config of VM 100 remained on node A. Checked
> that this also holds with `--force 1`, since it should only work with
> `--skip-config-check 1`. Did this for both running and stopped VMs.
> - Checked that the migration is possible with `--skip-config-check 1`,
> both online and offline. The option will then be dropped, as
> before.
> - Repeated the above for CTs. Used `--restart` here instead of
> `--online` for the migration and checked that an aborted migration
> due to the strict config check leaves the container running.
> - Simulated a lower version on node B and attempted to migrate. Checked
> that the migration was successful even with the added option due to
> the config check being skipped.
> - Ran migrations through the GUI with both 'Config check' on and off.
> Checked that the request had the fields set correctly and that the
> `skip-config-check` flag could also be used by non-root users, as
> opposed to --force.
> - Ran a migration on a HA-managed VM with `--with-conntrack-state 1`
> and checked that {"with-conntrack-state":"1"} showed up in the CRM
> command and checked the task log to ensure that the migration of
> conntrack state entries was performed.
> - Checked that `ha-manager help migrate` showed the correct parameters
> depending on the resource type and that `ha-manager migrate` rejected
> parameters that aren't valid for that resource type (used
> `--with-conntrack-state 1` for a CT).
> - Using `ha-manager migrate`, checked that HA-based migration is also
> aborted if a property is unknown to the target node. Then used
> `qm migrate ... --skip-config-check 1` for that HA-managed VM and
> checked that the migration was performed even with the additional
> property.
> - Added a positive affinity rule for VM 100 and CT 101. Then used
> `ha-manager migrate vm:100 node-b --with-conntrack-state 1` that
> the CT could also successfully be migrated even with the VM-only
> option supplied.
>
> I haven't noticed anything that hasn't been noticed before (e.g. that
> for CTs, the option will remain in the config when using
> `--skip-config-check 1` and will show warnings, whereas for VMs, it
> will be dropped). Overall, this seems to be in a pretty good state
> already. I noticed a few minor things, which I noted on the individual
> patches, but other than that, the series seems very solid to me and I
> think it's a very good addition.
>
> Consider this:
> Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
> Tested-by: Michael Köppl <m.koeppl@proxmox.com>
Thanks a lot for the thorough testing!
next prev parent reply other threads:[~2026-11-12 10:51 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 12:47 [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration Fiona Ebner
2026-11-03 12:47 ` [PATCH common v6 01/26] rest handler: handle: respect schema's 'type-property' when resolving type Fiona Ebner
2026-11-03 12:47 ` [PATCH cluster v6 02/26] cluster: add more convenience helpers for checking node versions Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 03/26] manager: add missing PVE::HA::Resources import Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 04/26] update crm commands: align logging with next state started/stopped Fiona Ebner
2026-11-03 12:47 ` [PATCH ha-manager v6 05/26] manager: factor out helper to check if requested resource motion is valid Fiona Ebner
2026-11-11 15:39 ` Michael Köppl
2026-11-12 11:00 ` Thomas Lamprecht
2026-11-12 11:07 ` Fiona Ebner
2026-11-12 11:21 ` Thomas Lamprecht
2026-11-12 11:52 ` Fiona Ebner
2026-11-12 12:23 ` Michael Köppl
2026-11-12 15:35 ` Thomas Lamprecht
2026-11-03 12:47 ` [PATCH ha-manager v6 06/26] next state stopped: align logging for motion command with next_state_started() Fiona Ebner
2026-11-11 15:39 ` Michael Köppl
2026-11-03 12:47 ` [PATCH ha-manager v6 07/26] next state {stopped,started}: factor out helper to handle motion command Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 08/26] lrm: resource migration: support extra migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 09/26] change service state: support hash as a parameter value Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 10/26] next state: handle motion command: support migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 11/26] resources: add migrate_json_properties() method Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 12/26] queue resource motion: support migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 13/26] crm command: support JSON-style migrate command Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 14/26] api: resources: migration: support additional migration options Fiona Ebner
2026-11-03 12:48 ` [PATCH ha-manager v6 15/26] test: add test for " Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 16/26] helpers: move get_node_pvecfg_version() version helper to pve-cluster Fiona Ebner
2026-11-11 15:39 ` Michael Köppl
2026-11-03 12:48 ` [PATCH qemu-server v6 17/26] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-11-11 15:40 ` Michael Köppl
2026-11-12 9:21 ` Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 18/26] fix #7053: api: migrate: pass 'with-conntrack-state' flag to HA migration Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 19/26] qm: mtunnel: reply when a command is unknown Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 20/26] qm: mtunnel: add 'conf' command to do strict configuration parsing Fiona Ebner
2026-11-03 12:48 ` [PATCH qemu-server v6 21/26] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-11-11 15:40 ` Michael Köppl
2026-11-12 9:38 ` Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 22/26] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 23/26] pct: introduce mtunnel command Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 24/26] d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 Fiona Ebner
2026-11-03 12:48 ` [PATCH container v6 25/26] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-11-11 15:41 ` Michael Köppl
2026-11-12 10:50 ` Fiona Ebner
2026-11-03 12:48 ` [PATCH manager v6 26/26] ui: migrate: add checkbox to allow skipping newly enforced config check Fiona Ebner
2026-11-08 23:35 ` applied: (subset) [PATCH-SERIES many v6 00/26] migration: strict config check for intra-cluster migration Thomas Lamprecht
2026-11-11 15:41 ` Michael Köppl
2026-11-11 15:51 ` Michael Köppl
2026-11-12 10:51 ` Fiona Ebner [this message]
2026-11-12 11:54 ` superseded: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01d620c9-d9e2-4ac5-9874-49252e6a6949@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox