Re: [PATCH pve-manager v2] fix #7187: report: add ethtool output for physical interfaces

[Erik Fastermann <e.fastermann@proxmox.com>]

On 5/13/26 10:21 AM, Erik Fastermann wrote:
> Adding ethtool output to pvereport provides visibility into actual and
> supported NIC link speeds, making it much easier to diagnose network
> performance issues, negotiation failures, and configuration mismatches.
> It also reduces support back-and-forth.
> 
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---

  NOTE: A similar patch was applied to all products:
  pmg, pve, pbs, pdm.

  changes since v1:
  * add a more detailed commit message explaining the rational
  * wrap in eval to prevent errors crashing the report
  * use PVE::Tools::shellquote to prevent injection errors

>   PVE/Report.pm | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 29433d4a..760ad905 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -3,6 +3,7 @@ package PVE::Report;
>   use strict;
>   use warnings;
>   
> +use PVE::IPRoute2;
>   use PVE::Tools;
>   
>   # output the content of all the files of a directory
> @@ -142,6 +143,21 @@ my $init_report_cmds = sub {
>           },
>       };
>   
> +    eval {
> +        my $interfaces = PVE::IPRoute2::ip_link_details();
> +
> +        for my $iface (sort keys %{$interfaces}) {
> +            if (PVE::IPRoute2::ip_link_is_physical($interfaces->{$iface})) {
> +                push @{ $report_def->{network}->{cmds} },
> +                    "ethtool " . PVE::Tools::shellquote($iface);
> +            }
> +        }
> +    };
> +
> +    if ($@) {
> +        print STDERR "building ethtool commands failed: $@";
> +    }
> +
>       if (cmd_exists('zfs')) {
>           push @{ $report_def->{volumes}->{cmds} },
>               'zpool status',