From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1D82A1FF13A for ; Wed, 13 May 2026 10:32:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 17BB53776; Wed, 13 May 2026 10:32:45 +0200 (CEST) Message-ID: <9062321e-2685-4276-a734-c5bb69b07d64@proxmox.com> Date: Wed, 13 May 2026 10:32:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pve-manager v2] fix #7187: report: add ethtool output for physical interfaces To: pve-devel@lists.proxmox.com References: <20260513082232.61872-1-e.fastermann@proxmox.com> Content-Language: en-US From: Erik Fastermann In-Reply-To: <20260513082232.61872-1-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778661015214 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.897 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [report.pm] Message-ID-Hash: 3MXSEP47KQTAQPZKHQABRM7XTCJUEKDO X-Message-ID-Hash: 3MXSEP47KQTAQPZKHQABRM7XTCJUEKDO X-MailFrom: e.fastermann@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/13/26 10:21 AM, Erik Fastermann wrote: > Adding ethtool output to pvereport provides visibility into actual and > supported NIC link speeds, making it much easier to diagnose network > performance issues, negotiation failures, and configuration mismatches. > It also reduces support back-and-forth. > > Signed-off-by: Erik Fastermann > --- NOTE: A similar patch was applied to all products: pmg, pve, pbs, pdm. changes since v1: * add a more detailed commit message explaining the rational * wrap in eval to prevent errors crashing the report * use PVE::Tools::shellquote to prevent injection errors > PVE/Report.pm | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/PVE/Report.pm b/PVE/Report.pm > index 29433d4a..760ad905 100644 > --- a/PVE/Report.pm > +++ b/PVE/Report.pm > @@ -3,6 +3,7 @@ package PVE::Report; > use strict; > use warnings; > > +use PVE::IPRoute2; > use PVE::Tools; > > # output the content of all the files of a directory > @@ -142,6 +143,21 @@ my $init_report_cmds = sub { > }, > }; > > + eval { > + my $interfaces = PVE::IPRoute2::ip_link_details(); > + > + for my $iface (sort keys %{$interfaces}) { > + if (PVE::IPRoute2::ip_link_is_physical($interfaces->{$iface})) { > + push @{ $report_def->{network}->{cmds} }, > + "ethtool " . PVE::Tools::shellquote($iface); > + } > + } > + }; > + > + if ($@) { > + print STDERR "building ethtool commands failed: $@"; > + } > + > if (cmd_exists('zfs')) { > push @{ $report_def->{volumes}->{cmds} }, > 'zpool status',