public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Erik Fastermann <e.fastermann@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH pve-manager v2] fix #7187: report: add ethtool output for physical interfaces
Date: Wed, 13 May 2026 10:22:32 +0200	[thread overview]
Message-ID: <20260513082232.61872-1-e.fastermann@proxmox.com> (raw)

Adding ethtool output to pvereport provides visibility into actual and
supported NIC link speeds, making it much easier to diagnose network
performance issues, negotiation failures, and configuration mismatches.
It also reduces support back-and-forth.

Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
 PVE/Report.pm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/PVE/Report.pm b/PVE/Report.pm
index 29433d4a..760ad905 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -3,6 +3,7 @@ package PVE::Report;
 use strict;
 use warnings;
 
+use PVE::IPRoute2;
 use PVE::Tools;
 
 # output the content of all the files of a directory
@@ -142,6 +143,21 @@ my $init_report_cmds = sub {
         },
     };
 
+    eval {
+        my $interfaces = PVE::IPRoute2::ip_link_details();
+
+        for my $iface (sort keys %{$interfaces}) {
+            if (PVE::IPRoute2::ip_link_is_physical($interfaces->{$iface})) {
+                push @{ $report_def->{network}->{cmds} },
+                    "ethtool " . PVE::Tools::shellquote($iface);
+            }
+        }
+    };
+
+    if ($@) {
+        print STDERR "building ethtool commands failed: $@";
+    }
+
     if (cmd_exists('zfs')) {
         push @{ $report_def->{volumes}->{cmds} },
             'zpool status',
-- 
2.47.3




             reply	other threads:[~2026-05-13  8:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13  8:22 Erik Fastermann [this message]
2026-05-13  8:32 ` [PATCH pve-manager v2] fix #7187: report: add ethtool output for physical interfaces Erik Fastermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260513082232.61872-1-e.fastermann@proxmox.com \
    --to=e.fastermann@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal