From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 045931FF13A for ; Wed, 13 May 2026 10:23:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A275A2DE3; Wed, 13 May 2026 10:23:10 +0200 (CEST) From: Erik Fastermann To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2] fix #7187: report: add ethtool output for physical interfaces Date: Wed, 13 May 2026 10:22:32 +0200 Message-ID: <20260513082232.61872-1-e.fastermann@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [report.pm] Message-ID-Hash: PJY5E3EEHYWQG5L5LGDS7IRUEPYW6FPW X-Message-ID-Hash: PJY5E3EEHYWQG5L5LGDS7IRUEPYW6FPW X-MailFrom: efastermann@ruth.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Erik Fastermann X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Adding ethtool output to pvereport provides visibility into actual and supported NIC link speeds, making it much easier to diagnose network performance issues, negotiation failures, and configuration mismatches. It also reduces support back-and-forth. Signed-off-by: Erik Fastermann --- PVE/Report.pm | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/PVE/Report.pm b/PVE/Report.pm index 29433d4a..760ad905 100644 --- a/PVE/Report.pm +++ b/PVE/Report.pm @@ -3,6 +3,7 @@ package PVE::Report; use strict; use warnings; +use PVE::IPRoute2; use PVE::Tools; # output the content of all the files of a directory @@ -142,6 +143,21 @@ my $init_report_cmds = sub { }, }; + eval { + my $interfaces = PVE::IPRoute2::ip_link_details(); + + for my $iface (sort keys %{$interfaces}) { + if (PVE::IPRoute2::ip_link_is_physical($interfaces->{$iface})) { + push @{ $report_def->{network}->{cmds} }, + "ethtool " . PVE::Tools::shellquote($iface); + } + } + }; + + if ($@) { + print STDERR "building ethtool commands failed: $@"; + } + if (cmd_exists('zfs')) { push @{ $report_def->{volumes}->{cmds} }, 'zpool status', -- 2.47.3