Re: [PATCH pve-cluster v5 2/7] datacenter config: add unique-next-id to schema

[Fiona Ebner <f.ebner@proxmox.com>]

Am 21.09.26 um 5:54 PM schrieb Michael Köppl:
> From: Severen Redwood <severen.redwood@sitehost.co.nz>
> 
> Add the `unique-next-id` property to the datacenter config schema to
> track whether only unique (ie. neither currently nor previously in use)
> VM/CT IDs should be suggested by the `/cluster/nextid` API endpoint.
> 
> Co-authored-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
> Signed-off-by: Severen Redwood <severen.redwood@sitehost.co.nz>
> [MK: use datacenter in commit message instead of datacentre]
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index 004122e..54f9c10 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -415,6 +415,12 @@ my $datacenter_schema = {
>              format => $next_id_format,
>              description => "Control the range for the free VMID auto-selection pool.",

Should we add this as a sub-property of the next-id property string
instead rather than a separate new option?

>          },
> +        'unique-next-id' => {
> +            optional => 1,
> +            type => 'boolean',
> +            description =>
> +                "Only suggest VMIDs that are neither currently in use nor have previously been used.",

Style nit: line too long
Nit: guest ID instead of VMID

> +        },
>          migration => {
>              optional => 1,
>              type => 'string',