From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C93F51FF0AA for ; Tue, 22 Sep 2026 16:22:45 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C7444215CF; Tue, 22 Sep 2026 16:22:34 +0200 (CEST) Message-ID: <8c347489-ccfe-498a-846b-6485e4014201@proxmox.com> Date: Tue, 22 Sep 2026 16:22:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-cluster v5 2/7] datacenter config: add unique-next-id to schema To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20260921155410.938337-1-m.koeppl@proxmox.com> <20260921155410.938337-3-m.koeppl@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260921155410.938337-3-m.koeppl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790086949625 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.532 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YG73MZH4Y44TEEMB2DJVF6ENO5JN35UY X-Message-ID-Hash: YG73MZH4Y44TEEMB2DJVF6ENO5JN35UY X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 21.09.26 um 5:54 PM schrieb Michael Köppl: > From: Severen Redwood > > Add the `unique-next-id` property to the datacenter config schema to > track whether only unique (ie. neither currently nor previously in use) > VM/CT IDs should be suggested by the `/cluster/nextid` API endpoint. > > Co-authored-by: Daniel Krambrock > Signed-off-by: Severen Redwood > [MK: use datacenter in commit message instead of datacentre] > Signed-off-by: Michael Köppl > --- > src/PVE/DataCenterConfig.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm > index 004122e..54f9c10 100644 > --- a/src/PVE/DataCenterConfig.pm > +++ b/src/PVE/DataCenterConfig.pm > @@ -415,6 +415,12 @@ my $datacenter_schema = { > format => $next_id_format, > description => "Control the range for the free VMID auto-selection pool.", Should we add this as a sub-property of the next-id property string instead rather than a separate new option? > }, > + 'unique-next-id' => { > + optional => 1, > + type => 'boolean', > + description => > + "Only suggest VMIDs that are neither currently in use nor have previously been used.", Style nit: line too long Nit: guest ID instead of VMID > + }, > migration => { > optional => 1, > type => 'string',