Re: [PATCH pve-cluster v5 1/7] cluster files: add used-guest-ids

[Fiona Ebner <f.ebner@proxmox.com>]

Am 21.09.26 um 5:54 PM schrieb Michael Köppl:
> From: Severen Redwood <severen.redwood@sitehost.co.nz>
> 
> Add `/etc/pve/used-guest-ids` to the list of cluster files, which will
> be used for recording previously used VM/CT IDs. This is required so
> that it can optionally be ensured that such IDs are not suggested.
> 
> Co-authored-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
> Signed-off-by: Severen Redwood <severen.redwood@sitehost.co.nz>
> [MK: change name of file to used-guest-ids
>      adapt commit message]
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
>  src/PVE/Cluster.pm  | 1 +
>  src/pmxcfs/status.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
> index 034b78c..aa6e93d 100644
> --- a/src/PVE/Cluster.pm
> +++ b/src/PVE/Cluster.pm
> @@ -92,6 +92,7 @@ my $observed = {
>      'mapping/directory.cfg' => 1,
>      'mapping/pci.cfg' => 1,
>      'mapping/usb.cfg' => 1,
> +    'used-guest-ids' => 1,

I'm wondering if we should avoid adding it to the top-level? There is
the virtual-guest directory already, where it would fit.

The name is slightly too much towards virtual machines IMHO, but it
already exists and we do also have the not-just-for-VMs (but
not-yet-in-use) profiles.cfg there:
https://lore.proxmox.com/pve-devel/20231117114548.3208470-2-d.csapak@proxmox.com/

>  };
>  
>  sub prepare_observed_file_basedirs {
> diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
> index 12a6c46..1b80c85 100644
> --- a/src/pmxcfs/status.c
> +++ b/src/pmxcfs/status.c
> @@ -120,6 +120,7 @@ static memdb_change_t memdb_change_array[] = {
>      {.path = "mapping/directory.cfg"},
>      {.path = "mapping/pci.cfg"},
>      {.path = "mapping/usb.cfg"},
> +    {.path = "used-guest-ids"},
>  };
>  
>  static GMutex mutex;