From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 020491FF0AA for ; Tue, 22 Sep 2026 16:22:29 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4E9612144F; Tue, 22 Sep 2026 16:22:26 +0200 (CEST) Message-ID: <66038a6d-1b75-4115-8671-741a535527c8@proxmox.com> Date: Tue, 22 Sep 2026 16:22:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-cluster v5 1/7] cluster files: add used-guest-ids To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20260921155410.938337-1-m.koeppl@proxmox.com> <20260921155410.938337-2-m.koeppl@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260921155410.938337-2-m.koeppl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790086940163 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.536 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GTPZKXDJO3ZXGSRFTV4G7O3XJ2CC6NQV X-Message-ID-Hash: GTPZKXDJO3ZXGSRFTV4G7O3XJ2CC6NQV X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 21.09.26 um 5:54 PM schrieb Michael Köppl: > From: Severen Redwood > > Add `/etc/pve/used-guest-ids` to the list of cluster files, which will > be used for recording previously used VM/CT IDs. This is required so > that it can optionally be ensured that such IDs are not suggested. > > Co-authored-by: Daniel Krambrock > Signed-off-by: Severen Redwood > [MK: change name of file to used-guest-ids > adapt commit message] > Signed-off-by: Michael Köppl > --- > src/PVE/Cluster.pm | 1 + > src/pmxcfs/status.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm > index 034b78c..aa6e93d 100644 > --- a/src/PVE/Cluster.pm > +++ b/src/PVE/Cluster.pm > @@ -92,6 +92,7 @@ my $observed = { > 'mapping/directory.cfg' => 1, > 'mapping/pci.cfg' => 1, > 'mapping/usb.cfg' => 1, > + 'used-guest-ids' => 1, I'm wondering if we should avoid adding it to the top-level? There is the virtual-guest directory already, where it would fit. The name is slightly too much towards virtual machines IMHO, but it already exists and we do also have the not-just-for-VMs (but not-yet-in-use) profiles.cfg there: https://lore.proxmox.com/pve-devel/20231117114548.3208470-2-d.csapak@proxmox.com/ > }; > > sub prepare_observed_file_basedirs { > diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c > index 12a6c46..1b80c85 100644 > --- a/src/pmxcfs/status.c > +++ b/src/pmxcfs/status.c > @@ -120,6 +120,7 @@ static memdb_change_t memdb_change_array[] = { > {.path = "mapping/directory.cfg"}, > {.path = "mapping/pci.cfg"}, > {.path = "mapping/usb.cfg"}, > + {.path = "used-guest-ids"}, > }; > > static GMutex mutex;