Re: [PATCH manager v2 0/4] fix #7801: ui: warn about problematic virtio versions on iso select

[Dominik Csapak <d.csapak@proxmox.com>]

high level question: could it make sense to have this
warning also on the backend, e.g. in the start task?

that way a user only using the cli/api would also see it, not
only the ui users.

if that makes sense, we might want to keep a list
of versions on the backend and expose it via the api
for the gui?

on the backend we could even match the sha256 sum or something like
that (if that's not too much of a performance hit on start) to
check if it's really the right version

On 8/26/26 9:49 AM, Nicolas Frey wrote:
> fixes #7801 by scanning for virtio filename regex and warning the user
> if the version has known issues attributed to it [0].
> 
> I tried the following approaches to warn the user:
> * via a (quite intrusive) pop-up
> * a warning box after the iso selector
> * an inline hoverable icon on the selector field
> 
> I felt the second approach resulted in the best UX, so I went with
> that in this series.
> 
> Changes since v1 (thanks Maximiliano!):
> * use single gettext call for warning message
> * remove the detailed hints about which version to switch to,
>    instead rely on the link to the wiki
> * actually lazily evaluate the ostype in patch [4/4] by putting it in
>    the function body that gets returned (i.e. the factory)
> * add missing warnVirtio to commonOpts
> 
> [0] https://pve.proxmox.com/wiki/Windows_VirtIO_Drivers
> 
> pve-manager:
> 
> Nicolas Frey (4):
>    ui: iso selector: add option to warn about virtio versions with issues
>    ui: cd edit: add `warnVirtio` option to pass to iso selector
>    partially fix #7801: ui: ospanel: warn about problematic virtio
>      versions
>    partially fix #7801: ui: hardware view: warn about problematic virtio
>      versions
> 
>   www/manager6/form/IsoSelector.js  | 70 ++++++++++++++++++++++++++++++-
>   www/manager6/qemu/CDEdit.js       |  4 ++
>   www/manager6/qemu/HardwareView.js |  8 ++--
>   www/manager6/qemu/OSPanel.js      |  1 +
>   4 files changed, 78 insertions(+), 5 deletions(-)
> 
> 
> Summary over all repositories:
>    4 files changed, 78 insertions(+), 5 deletions(-)
> 
> --
> Generated by murpp 0.12.1