From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2 0/4] fix #7801: ui: warn about problematic virtio versions on iso select
Date: Wed, 26 Aug 2026 09:49:31 +0200 [thread overview]
Message-ID: <20260826074935.78437-1-n.frey@proxmox.com> (raw)
fixes #7801 by scanning for virtio filename regex and warning the user
if the version has known issues attributed to it [0].
I tried the following approaches to warn the user:
* via a (quite intrusive) pop-up
* a warning box after the iso selector
* an inline hoverable icon on the selector field
I felt the second approach resulted in the best UX, so I went with
that in this series.
Changes since v1 (thanks Maximiliano!):
* use single gettext call for warning message
* remove the detailed hints about which version to switch to,
instead rely on the link to the wiki
* actually lazily evaluate the ostype in patch [4/4] by putting it in
the function body that gets returned (i.e. the factory)
* add missing warnVirtio to commonOpts
[0] https://pve.proxmox.com/wiki/Windows_VirtIO_Drivers
pve-manager:
Nicolas Frey (4):
ui: iso selector: add option to warn about virtio versions with issues
ui: cd edit: add `warnVirtio` option to pass to iso selector
partially fix #7801: ui: ospanel: warn about problematic virtio
versions
partially fix #7801: ui: hardware view: warn about problematic virtio
versions
www/manager6/form/IsoSelector.js | 70 ++++++++++++++++++++++++++++++-
www/manager6/qemu/CDEdit.js | 4 ++
www/manager6/qemu/HardwareView.js | 8 ++--
www/manager6/qemu/OSPanel.js | 1 +
4 files changed, 78 insertions(+), 5 deletions(-)
Summary over all repositories:
4 files changed, 78 insertions(+), 5 deletions(-)
--
Generated by murpp 0.12.1
next reply other threads:[~2026-08-26 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 7:49 Nicolas Frey [this message]
2026-08-26 7:49 ` [PATCH pve-manager v2 1/4] ui: iso selector: add option to warn about virtio versions with issues Nicolas Frey
2026-08-26 11:44 ` Fiona Ebner
2026-08-26 13:28 ` Nicolas Frey
2026-08-26 7:49 ` [PATCH pve-manager v2 2/4] ui: cd edit: add `warnVirtio` option to pass to iso selector Nicolas Frey
2026-08-26 7:49 ` [PATCH pve-manager v2 3/4] partially fix #7801: ui: ospanel: warn about problematic virtio versions Nicolas Frey
2026-08-26 7:49 ` [PATCH pve-manager v2 4/4] partially fix #7801: ui: hardware view: " Nicolas Frey
2026-08-26 11:44 ` Fiona Ebner
2026-08-26 13:38 ` Nicolas Frey
2026-08-26 14:09 ` Fiona Ebner
2026-08-27 6:14 ` [PATCH manager v2 0/4] fix #7801: ui: warn about problematic virtio versions on iso select Dominik Csapak
2026-08-27 6:57 ` Nicolas Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260826074935.78437-1-n.frey@proxmox.com \
--to=n.frey@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox