From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1A9411FF0E7 for ; Thu, 27 Aug 2026 08:14:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3BF452134B; Thu, 27 Aug 2026 08:14:56 +0200 (CEST) Message-ID: <81015da8-5e46-4adc-8c0e-73794bb6ea79@proxmox.com> Date: Thu, 27 Aug 2026 08:14:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager v2 0/4] fix #7801: ui: warn about problematic virtio versions on iso select To: Nicolas Frey , pve-devel@lists.proxmox.com References: <20260826074935.78437-1-n.frey@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260826074935.78437-1-n.frey@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787811278969 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.700 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CFAK4NAE3KXAQPPCNLO4OYHJOGDDTNL6 X-Message-ID-Hash: CFAK4NAE3KXAQPPCNLO4OYHJOGDDTNL6 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: high level question: could it make sense to have this warning also on the backend, e.g. in the start task? that way a user only using the cli/api would also see it, not only the ui users. if that makes sense, we might want to keep a list of versions on the backend and expose it via the api for the gui? on the backend we could even match the sha256 sum or something like that (if that's not too much of a performance hit on start) to check if it's really the right version On 8/26/26 9:49 AM, Nicolas Frey wrote: > fixes #7801 by scanning for virtio filename regex and warning the user > if the version has known issues attributed to it [0]. > > I tried the following approaches to warn the user: > * via a (quite intrusive) pop-up > * a warning box after the iso selector > * an inline hoverable icon on the selector field > > I felt the second approach resulted in the best UX, so I went with > that in this series. > > Changes since v1 (thanks Maximiliano!): > * use single gettext call for warning message > * remove the detailed hints about which version to switch to, > instead rely on the link to the wiki > * actually lazily evaluate the ostype in patch [4/4] by putting it in > the function body that gets returned (i.e. the factory) > * add missing warnVirtio to commonOpts > > [0] https://pve.proxmox.com/wiki/Windows_VirtIO_Drivers > > pve-manager: > > Nicolas Frey (4): > ui: iso selector: add option to warn about virtio versions with issues > ui: cd edit: add `warnVirtio` option to pass to iso selector > partially fix #7801: ui: ospanel: warn about problematic virtio > versions > partially fix #7801: ui: hardware view: warn about problematic virtio > versions > > www/manager6/form/IsoSelector.js | 70 ++++++++++++++++++++++++++++++- > www/manager6/qemu/CDEdit.js | 4 ++ > www/manager6/qemu/HardwareView.js | 8 ++-- > www/manager6/qemu/OSPanel.js | 1 + > 4 files changed, 78 insertions(+), 5 deletions(-) > > > Summary over all repositories: > 4 files changed, 78 insertions(+), 5 deletions(-) > > -- > Generated by murpp 0.12.1