[PATCH manager/pmg-gui/proxmox-backup/widget-toolkit v3 0/4] blurry icons follow-up

[PATCH manager/pmg-gui/proxmox-backup/widget-toolkit v3 0/4] blurry icons follow-up

[Shannon Sterz]

this series is a small follow-up to the recent series that removed all custom
blurry icons from proxmox ve [1]. parts of these series have been applied
previously [2]. these remaining patches move the `.x-grid-row-loading` class to
proxmox-widget-toolkit, ensuring that only the svg-based spinner is used.

[1]: https://lore.proxmox.com/all/20250826145836.302748-2-s.sterz@proxmox.com/
[2]: https://lore.proxmox.com/all/20250829141219.290626-2-s.sterz@proxmox.com/


widget-toolkit:

Shannon Sterz (1):
  css: move x-grid-row-loading class to widget-toolkit

 src/css/ext6-pmx.css | 5 +++++
 1 file changed, 5 insertions(+)


manager:

Shannon Sterz (1):
  ui: remove x-grid-row-loading class and spinner svg

 www/css/ext6-pve.css   |  6 ------
 www/images/Makefile    |  1 -
 www/images/spinner.svg | 24 ------------------------
 3 files changed, 31 deletions(-)
 delete mode 100644 www/images/spinner.svg


backup:

Shannon Sterz (1):
  css: remove x-grid-row-loading class

 www/css/ext6-pbs.css | 6 ------
 1 file changed, 6 deletions(-)


pmg-gui:

Shannon Sterz (1):
  css: remove x-grid-row-loading class

 css/ext6-pmg.css | 6 ------
 1 file changed, 6 deletions(-)


Summary over all repositories:
  6 files changed, 5 insertions(+), 43 deletions(-)

-- 
Generated by murpp 0.10.0

[PATCH widget-toolkit v3 1/4] css: move x-grid-row-loading class to widget-toolkit

[Shannon Sterz]

this class previously existed across all three of our products. since
the definition was identical, move it here to keep it in one place.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/css/ext6-pmx.css | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
index 37d4410..d8d9b8d 100644
--- a/src/css/ext6-pmx.css
+++ b/src/css/ext6-pmx.css
@@ -220,6 +220,11 @@ div.right-aligned {
     background-image: url(../images/openid-icon.svg);
 }
 
+.x-grid-row-loading {
+    background: no-repeat center center;
+    background-image: url(../images/spinner.svg);
+}
+
 /* fix up extjs spinners with our svg spinner */
 .x-treelist-item-loading .x-treelist-item-icon,
 .x-treelist-nav .x-treelist-item-loading .x-treelist-item-icon,
-- 
2.47.3

[PATCH manager v3 2/4] ui: remove x-grid-row-loading class and spinner svg

[Shannon Sterz]

the class was moved to the widget toolkit and should be used from
there directly. this also removes the svg-based spinner here, as the
widget toolkit ships its own version and pve-manager doesn't use it
anymore directly.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/css/ext6-pve.css   |  6 ------
 www/images/Makefile    |  1 -
 www/images/spinner.svg | 24 ------------------------
 3 files changed, 31 deletions(-)
 delete mode 100644 www/images/spinner.svg

diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css
index 27742a74b..5c37dd291 100644
--- a/www/css/ext6-pve.css
+++ b/www/css/ext6-pve.css
@@ -89,12 +89,6 @@
     content: "\f115";
 }
 
-/* loading in task list */
-.x-grid-row-loading {
-    background: no-repeat center center;
-    background-image: url(../images/spinner.svg);
-}
-
 /* for font-awesome colors */
 /* tree icons */
 
diff --git a/www/images/Makefile b/www/images/Makefile
index 57631a87c..e5e72eb1d 100644
--- a/www/images/Makefile
+++ b/www/images/Makefile
@@ -40,7 +40,6 @@ IMAGES =			\
 	icon-cpu.svg		\
 	icon-memory.svg		\
 	icon-cd-drive.svg	\
-	spinner.svg		\
 
 icon-sdn.svg: icon-sdn.dot
 	fdp -Tsvg $< > $@
diff --git a/www/images/spinner.svg b/www/images/spinner.svg
deleted file mode 100644
index 3d2a63c0d..000000000
--- a/www/images/spinner.svg
+++ /dev/null
@@ -1,24 +0,0 @@
-<svg version="1.1" viewBox="-13 -13 26 26" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
-<style>
-        @keyframes frames {
-            from { transform: rotate(0deg); }
-            to { transform: rotate(360deg); }
-        }
-        .spinner { animation: frames 1.2s steps(12, jump-start) infinite; }
-</style>
-<g stroke-linecap="round" stroke-width="2">
-<path class="spinner" id="a" d="m0 -8 0,4"/>
-<use transform="rotate(30)" xlink:href="#a" stroke="#eaeaea"/>
-<use transform="rotate(60)" xlink:href="#a" stroke="#d4d4d4"/>
-<use transform="rotate(90)" xlink:href="#a" stroke="#bfbfbf"/>
-<use transform="rotate(120)" xlink:href="#a" stroke="#aaaaaa"/>
-<use transform="rotate(150)" xlink:href="#a" stroke="#959595"/>
-<use transform="rotate(180)" xlink:href="#a" stroke="#808080"/>
-<use transform="rotate(210)" xlink:href="#a" stroke="#6a6a6a"/>
-<use transform="rotate(240)" xlink:href="#a" stroke="#555555"/>
-<use transform="rotate(270)" xlink:href="#a" stroke="#404040"/>
-<use transform="rotate(300)" xlink:href="#a" stroke="#2a2a2a"/>
-<use transform="rotate(330)" xlink:href="#a" stroke="#151515"/>
-<use transform="rotate(360)" xlink:href="#a" stroke="#000000"/>
-</g>
-</svg>
-- 
2.47.3

[PATCH proxmox-backup v3 3/4] css: remove x-grid-row-loading class

[Shannon Sterz]

as it was moved to the widget-toolkit and should be used from there.
since the version in the widget toolkit uses an svg-based spinner,
this has the effect of rendering the spinner without blur.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 www/css/ext6-pbs.css | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
index 4a4a58d2..83c029d7 100644
--- a/www/css/ext6-pbs.css
+++ b/www/css/ext6-pbs.css
@@ -89,12 +89,6 @@
     color: black;
 }
 
-/* loading in task list */
-.x-grid-row-loading {
-    background: no-repeat center center;
-    background-image: url(../extjs/theme-crisp/resources/images/loadmask/loading.gif);
-}
-
 /* displayfield minheight is wrong */
 .x-form-display-field-default {
     min-height: 20px;
-- 
2.47.3

[PATCH pmg-gui v3 4/4] css: remove x-grid-row-loading class

[Shannon Sterz]

as it was moved to the widget-toolkit and should be used from there.
since the version in the widget toolkit uses an svg-based spinner,
this has the effect of rendering the spinner without blur.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 css/ext6-pmg.css | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/css/ext6-pmg.css b/css/ext6-pmg.css
index a6042aa..8f578dc 100644
--- a/css/ext6-pmg.css
+++ b/css/ext6-pmg.css
@@ -109,12 +109,6 @@
     content: "\f115";
 }
 
-/* loading in task list */
-.x-grid-row-loading {
-    background: no-repeat center center;
-    background-image: url(../ext6/theme-crisp/resources/images/loadmask/loading.gif);
-}
-
 /* displayfield minheight is wrong */
 .x-form-display-field-default {
     min-height: 20px;
-- 
2.47.3

Re: [PATCH manager/pmg-gui/proxmox-backup/widget-toolkit v3 0/4] blurry icons follow-up

[Dominik Csapak]

LGTM

don't applying these directly since it involves
a bump/dependency cycle (i don't want to interfere here @Thomas),
but consider them

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 4/17/26 10:24 AM, Shannon Sterz wrote:
> this series is a small follow-up to the recent series that removed all custom
> blurry icons from proxmox ve [1]. parts of these series have been applied
> previously [2]. these remaining patches move the `.x-grid-row-loading` class to
> proxmox-widget-toolkit, ensuring that only the svg-based spinner is used.
> 
> [1]: https://lore.proxmox.com/all/20250826145836.302748-2-s.sterz@proxmox.com/
> [2]: https://lore.proxmox.com/all/20250829141219.290626-2-s.sterz@proxmox.com/
> 
> 
> widget-toolkit:
> 
> Shannon Sterz (1):
>    css: move x-grid-row-loading class to widget-toolkit
> 
>   src/css/ext6-pmx.css | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> 
> manager:
> 
> Shannon Sterz (1):
>    ui: remove x-grid-row-loading class and spinner svg
> 
>   www/css/ext6-pve.css   |  6 ------
>   www/images/Makefile    |  1 -
>   www/images/spinner.svg | 24 ------------------------
>   3 files changed, 31 deletions(-)
>   delete mode 100644 www/images/spinner.svg
> 
> 
> backup:
> 
> Shannon Sterz (1):
>    css: remove x-grid-row-loading class
> 
>   www/css/ext6-pbs.css | 6 ------
>   1 file changed, 6 deletions(-)
> 
> 
> pmg-gui:
> 
> Shannon Sterz (1):
>    css: remove x-grid-row-loading class
> 
>   css/ext6-pmg.css | 6 ------
>   1 file changed, 6 deletions(-)
> 
> 
> Summary over all repositories:
>    6 files changed, 5 insertions(+), 43 deletions(-)
>