public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>, pve-devel@lists.proxmox.com
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [PATCH manager/pmg-gui/proxmox-backup/widget-toolkit v3 0/4] blurry icons follow-up
Date: Fri, 17 Apr 2026 16:25:54 +0200	[thread overview]
Message-ID: <517ed812-4e79-4757-b082-1a4f5fbe3a17@proxmox.com> (raw)
In-Reply-To: <20260417082504.35648-1-s.sterz@proxmox.com>

LGTM

don't applying these directly since it involves
a bump/dependency cycle (i don't want to interfere here @Thomas),
but consider them

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 4/17/26 10:24 AM, Shannon Sterz wrote:
> this series is a small follow-up to the recent series that removed all custom
> blurry icons from proxmox ve [1]. parts of these series have been applied
> previously [2]. these remaining patches move the `.x-grid-row-loading` class to
> proxmox-widget-toolkit, ensuring that only the svg-based spinner is used.
> 
> [1]: https://lore.proxmox.com/all/20250826145836.302748-2-s.sterz@proxmox.com/
> [2]: https://lore.proxmox.com/all/20250829141219.290626-2-s.sterz@proxmox.com/
> 
> 
> widget-toolkit:
> 
> Shannon Sterz (1):
>    css: move x-grid-row-loading class to widget-toolkit
> 
>   src/css/ext6-pmx.css | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> 
> manager:
> 
> Shannon Sterz (1):
>    ui: remove x-grid-row-loading class and spinner svg
> 
>   www/css/ext6-pve.css   |  6 ------
>   www/images/Makefile    |  1 -
>   www/images/spinner.svg | 24 ------------------------
>   3 files changed, 31 deletions(-)
>   delete mode 100644 www/images/spinner.svg
> 
> 
> backup:
> 
> Shannon Sterz (1):
>    css: remove x-grid-row-loading class
> 
>   www/css/ext6-pbs.css | 6 ------
>   1 file changed, 6 deletions(-)
> 
> 
> pmg-gui:
> 
> Shannon Sterz (1):
>    css: remove x-grid-row-loading class
> 
>   css/ext6-pmg.css | 6 ------
>   1 file changed, 6 deletions(-)
> 
> 
> Summary over all repositories:
>    6 files changed, 5 insertions(+), 43 deletions(-)
> 





      parent reply	other threads:[~2026-04-17 14:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  8:25 Shannon Sterz
2026-04-17  8:25 ` [PATCH widget-toolkit v3 1/4] css: move x-grid-row-loading class to widget-toolkit Shannon Sterz
2026-04-17  8:25 ` [PATCH manager v3 2/4] ui: remove x-grid-row-loading class and spinner svg Shannon Sterz
2026-04-17  8:25 ` [PATCH proxmox-backup v3 3/4] css: remove x-grid-row-loading class Shannon Sterz
2026-04-17  8:25 ` [PATCH pmg-gui v3 4/4] " Shannon Sterz
2026-04-17 14:25 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517ed812-4e79-4757-b082-1a4f5fbe3a17@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal