public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager 26/34] api: cluster resources: add guest uid and registration time
Date: Tue, 17 Nov 2026 16:30:38 +0100	[thread overview]
Message-ID: <46a55251-568f-4335-8f4f-a720970ce079@proxmox.com> (raw)
In-Reply-To: <20261116004703.2908294-27-t.lamprecht@proxmox.com>

nit inline

On 11/16/26 1:51 AM, Thomas Lamprecht wrote:
> Tools that follow guests across restores and migrations, for example
> backup products, need the guest identity. Report the 'uid' and 'rtime'
> of guests that have them on their rows, so such tools get both for all
> guests with one call instead of reading each guest config. Like lock
> and tags, they are only reported to users with VM.Audit on the guest.
> 
> Both come from the 'meta' line, which the existing request for lock and
> tags now also returns, so there is no extra round trip to pmxcfs. The
> line is parsed per guest, and a guest with a missing or malformed
> identity only lacks the fields. Neither the raw line nor its other
> members are exposed.
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> ---
>   PVE/API2/Cluster.pm           |  25 +++-
>   test/ClusterResources_test.pl | 249 ++++++++++++++++++++++++++++++++++
>   test/Makefile                 |   6 +-
>   3 files changed, 278 insertions(+), 2 deletions(-)
>   create mode 100755 test/ClusterResources_test.pl
> 
> diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
> index 4e5efbfd..346ecdb2 100644
> --- a/PVE/API2/Cluster.pm
> +++ b/PVE/API2/Cluster.pm
> @@ -11,6 +11,7 @@ use PVE::DataCenterConfig;
>   use PVE::Exception qw(raise_param_exc);
>   use PVE::Firewall;
>   use PVE::GuestHelpers;
> +use PVE::GuestIdentity;
>   use PVE::HA::Config;
>   use PVE::HA::Env::PVE2;
>   use PVE::INotify;
> @@ -474,6 +475,22 @@ __PACKAGE__->register_method({
>                       optional => 1,
>                       default => 0,
>                   },
> +                uid => {
> +                    description =>
> +                        "Guest lineage identifier, normally kept across restores and migrations"
> +                        . " from other clusters (for types 'qemu' and 'lxc').",
> +                    type => 'string',
> +                    optional => 1,
> +                },
> +                rtime => {
> +                    description =>
> +                        "Time the guest was registered in this cluster, for example by"
> +                        . " creation, restore, or migration from another cluster, in milliseconds"
> +                        . " since the UNIX epoch (for types 'qemu' and 'lxc').",
> +                    type => 'integer',
> +                    minimum => 0,
> +                    optional => 1,
> +                },
>                   network => {
>                       description => "The name of a Network entity (for type 'network').",
>                       type => "string",
> @@ -552,7 +569,7 @@ __PACKAGE__->register_method({
>           # we try to generate 'numbers' by using "$X + 0"
>           if (!$param->{type} || $param->{type} eq 'vm') {
>               my $prop_list = [qw(lock tags)];
> -            my $props = PVE::Cluster::get_guest_config_properties($prop_list);
> +            my $props = PVE::Cluster::get_guest_config_properties([@$prop_list, 'meta']);
>   

nit: this could simply add 'meta' to the prop_list

>               for my $vmid (sort keys %$idlist) {
>   
> @@ -593,6 +610,12 @@ __PACKAGE__->register_method({
>                       }
>                   }
>   
> +                my $identity = PVE::GuestIdentity::parse_identity($props->{$vmid}->{meta});
> +                if ($identity) {
> +                    $entry->{uid} = $identity->{uid};
> +                    $entry->{rtime} = int($identity->{rtime}) if defined($identity->{rtime});
> +                }
> +

and here we'd instead do

if (my $meta = parse_identity(delete $entry->{meta})) {
     $entry->{...}

}

but this is more of a taste question

>                   if (
>                       defined($entry->{pool})
>                       && !$rpcenv->check($authuser, "/pool/$entry->{pool}", ['Pool.Audit'], 1)




  reply	other threads:[~2026-11-17 15:30 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:46 [PATCH cluster/guest-common/qemu-server/container/manager/docs 00/34] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 01/34] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 02/34] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 03/34] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 04/34] pmxcfs: quorum: pass the corosync membership to an optional listener Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 05/34] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 06/34] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH cluster 07/34] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-16  0:46 ` [PATCH guest-common 08/34] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-17 10:47   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH guest-common 09/34] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-17 10:47   ` Dominik Csapak
2026-11-17 12:47     ` Dominik Csapak
2026-11-16  0:46 ` [PATCH guest-common 10/34] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-16  0:46 ` [PATCH guest-common 11/34] guest identity: allow taking over a uid that is unused in the cluster Thomas Lamprecht
2026-11-17 13:14   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH qemu-server 12/34] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 13/34] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 14/34] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-16  0:46 ` [PATCH qemu-server 15/34] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-17 15:17   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH qemu-server 16/34] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-17 15:26   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH qemu-server 17/34] api: status: return the guest uid Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 18/34] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 19/34] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 20/34] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 21/34] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 22/34] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 23/34] migrate: remote: clean up the target on a tunnel version mismatch Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 24/34] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-16  0:46 ` [PATCH container 25/34] api: status: return the guest uid Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 26/34] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-17 15:30   ` Dominik Csapak [this message]
2026-11-16  0:46 ` [PATCH manager 27/34] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 28/34] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 29/34] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-16  0:46 ` [PATCH manager 30/34] ui: guest summary: show " Thomas Lamprecht
2026-11-17 15:44   ` Dominik Csapak
2026-11-16  0:46 ` [PATCH docs 31/34] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 32/34] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 33/34] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-16  0:46 ` [PATCH docs 34/34] pct: " Thomas Lamprecht
2026-11-17 10:47 ` [PATCH cluster/guest-common/qemu-server/container/manager/docs 00/34] fix #7846: guest identity (uid) and cluster ID Dominik Csapak
2026-11-17 11:29   ` Thomas Lamprecht
2026-11-17 11:55     ` Dominik Csapak
2026-11-17 12:47       ` Thomas Lamprecht
2026-11-17 13:54         ` Dominik Csapak
2026-11-17 15:55 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a55251-568f-4335-8f4f-a720970ce079@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal