Re: [PATCH manager 09/19] vzdump: run job-init hook and set up target once the job may start

[Fiona Ebner <f.ebner@proxmox.com>]

Am 01.11.26 um 11:59 PM schrieb Thomas Lamprecht:
> @@ -714,7 +724,7 @@ sub new {
>          die "internal error";
>      }
>  
> -    $opts->{'prune-backups'} //= $defaults->{'prune-backups'};
> +    $opts->{'prune-backups'} //= $self->{'default-prune-backups'};
>  
>      # avoid triggering any remove code path if keep-all is set
>      $opts->{remove} = 0 if $opts->{'prune-backups'}->{'keep-all'};
> @@ -723,13 +733,7 @@ sub new {
>          $add_error->("tmpdir '$opts->{tmpdir}' does not exist");
>      }
>  
> -    if ($errors) {
> -        eval { $self->send_notification([], 0, $errors); };
> -        debugmsg('err', $@) if $@;

The send_notification() call in API2::VZDump is not eval'd and does not
have a debugmsg() call. Should we change that? For one, to preserve the
error handling behavior here and also to improve that call-site in general.

> -        die "$errors\n";
> -    }
> -
> -    return $self;
> +    die "$errors\n" if $errors;
>  }
>  
>  sub get_mount_info {