From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id A0C381FF0AF
	for <inbox@lore.proxmox.com>; Fri, 06 Nov 2026 15:49:04 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id A439521536;
	Fri, 06 Nov 2026 15:49:02 +0100 (CET)
Message-ID: <35eee257-d86d-449d-96e1-b010b46cca3e@proxmox.com>
Date: Fri, 6 Nov 2026 15:48:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH manager 09/19] vzdump: run job-init hook and set up target
 once the job may start
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
References: <20261101225849.884587-1-t.lamprecht@proxmox.com>
 <20261101225849.884587-10-t.lamprecht@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20261101225849.884587-10-t.lamprecht@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793976539131
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.291 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: WMIZWZP4EXHFOET4CKISUEO6HOA2BASQ
X-Message-ID-Hash: WMIZWZP4EXHFOET4CKISUEO6HOA2BASQ
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 01.11.26 um 11:59 PM schrieb Thomas Lamprecht:
> @@ -714,7 +724,7 @@ sub new {
>          die "internal error";
>      }
>  
> -    $opts->{'prune-backups'} //= $defaults->{'prune-backups'};
> +    $opts->{'prune-backups'} //= $self->{'default-prune-backups'};
>  
>      # avoid triggering any remove code path if keep-all is set
>      $opts->{remove} = 0 if $opts->{'prune-backups'}->{'keep-all'};
> @@ -723,13 +733,7 @@ sub new {
>          $add_error->("tmpdir '$opts->{tmpdir}' does not exist");
>      }
>  
> -    if ($errors) {
> -        eval { $self->send_notification([], 0, $errors); };
> -        debugmsg('err', $@) if $@;

The send_notification() call in API2::VZDump is not eval'd and does not
have a debugmsg() call. Should we change that? For one, to preserve the
error handling behavior here and also to improve that call-site in general.

> -        die "$errors\n";
> -    }
> -
> -    return $self;
> +    die "$errors\n" if $errors;
>  }
>  
>  sub get_mount_info {